Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code

Delta Between Two Patch Sets: lib/utils.js

Issue 29374674: Issue 4864 - Start using ESLint for adblockpluschrome (Closed)
Left Patch Set: Addressed some of Sebastian's feedback, made other improvements Created Feb. 20, 2017, 10:06 a.m.
Right Patch Set: Use .includes again Created March 31, 2017, 8:37 a.m.
Left:
Right:
Use n/p to move between diff chunks; N/P to move between comments.
Jump to:
Left: Side by side diff | Download
Right: Side by side diff | Download
« no previous file with change/comment | « lib/url.js ('k') | lib/whitelisting.js » ('j') | no next file with change/comment »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
LEFTRIGHT
1 /* 1 /*
2 * This file is part of Adblock Plus <https://adblockplus.org/>, 2 * This file is part of Adblock Plus <https://adblockplus.org/>,
3 * Copyright (C) 2006-2016 Eyeo GmbH 3 * Copyright (C) 2006-2017 eyeo GmbH
4 * 4 *
5 * Adblock Plus is free software: you can redistribute it and/or modify 5 * Adblock Plus is free software: you can redistribute it and/or modify
6 * it under the terms of the GNU General Public License version 3 as 6 * it under the terms of the GNU General Public License version 3 as
7 * published by the Free Software Foundation. 7 * published by the Free Software Foundation.
8 * 8 *
9 * Adblock Plus is distributed in the hope that it will be useful, 9 * Adblock Plus is distributed in the hope that it will be useful,
10 * but WITHOUT ANY WARRANTY; without even the implied warranty of 10 * but WITHOUT ANY WARRANTY; without even the implied warranty of
11 * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the 11 * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
12 * GNU General Public License for more details. 12 * GNU General Public License for more details.
13 * 13 *
(...skipping 16 matching lines...) Expand all
30 // Make sure to not run asynchronous actions before all 30 // Make sure to not run asynchronous actions before all
31 // scripts loaded. This caused issues on Opera in the past. 31 // scripts loaded. This caused issues on Opera in the past.
32 let onDOMContentLoaded = () => 32 let onDOMContentLoaded = () =>
33 { 33 {
34 document.removeEventListener("DOMContentLoaded", onDOMContentLoaded); 34 document.removeEventListener("DOMContentLoaded", onDOMContentLoaded);
35 callback(); 35 callback();
36 }; 36 };
37 document.addEventListener("DOMContentLoaded", onDOMContentLoaded); 37 document.addEventListener("DOMContentLoaded", onDOMContentLoaded);
38 } 38 }
39 else 39 else
40 {
40 setTimeout(callback, 0); 41 setTimeout(callback, 0);
42 }
41 }, 43 },
42 get appLocale() 44 get appLocale()
43 { 45 {
44 let locale = ext.i18n.getMessage("@@ui_locale").replace(/_/g, "-"); 46 let locale = ext.i18n.getMessage("@@ui_locale").replace(/_/g, "-");
45 Object.defineProperty(this, "appLocale", {value: locale, enumerable: true}); 47 Object.defineProperty(this, "appLocale", {value: locale, enumerable: true});
46 return this.appLocale; 48 return this.appLocale;
47 }, 49 },
48 generateChecksum(lines) 50 generateChecksum(lines)
49 { 51 {
50 // We cannot calculate MD5 checksums yet :-( 52 // We cannot calculate MD5 checksums yet :-(
(...skipping 49 matching lines...) Expand 10 before | Expand all | Expand 10 after
100 } 102 }
101 } 103 }
102 } 104 }
103 } 105 }
104 return selectedItem; 106 return selectedItem;
105 }, 107 },
106 108
107 getDocLink(linkID) 109 getDocLink(linkID)
108 { 110 {
109 let docLink = require("prefs").Prefs.documentation_link; 111 let docLink = require("prefs").Prefs.documentation_link;
110 return docLink.replace(/%LINK%/g, linkID).replace(/%LANG%/g, 112 return docLink.replace(/%LINK%/g, linkID)
111 Utils.appLocale); 113 .replace(/%LANG%/g, Utils.appLocale);
112 }, 114 },
113 115
114 yield() 116 yield()
115 { 117 {
116 } 118 }
117 }; 119 };
LEFTRIGHT

Powered by Google App Engine
This is Rietveld