Issue 4864 - Start using ESLint for adblockpluschrome

chrome/ext/popup.js

 "use strict";
 
 (function()
 {
   const backgroundPage = chrome.extension.getBackgroundPage();
-  ext = Object.create(backgroundPage.ext);

[Wladimir Palant, 2017/03/14 13:03:22]

As far as the browser is concerned, ext is an undeclared variable here. So IMHO
this should throw because of "use strict". Assign to window.ext instead?

[kzar, 2017/03/15 04:57:44]

Done.

+  window.ext = Object.create(backgroundPage.ext);
 
-  ext.closePopup = () =>
+  window.ext.closePopup = () =>
   {
     window.close();
   };
 
   // We have to override ext.backgroundPage, because in order
   // to send messages the local "chrome" namespace must be used.
-  ext.backgroundPage = {
+  window.ext.backgroundPage = {
     sendMessage: chrome.runtime.sendMessage,
 
     getWindow()
     {
       return backgroundPage;
     }
   };
 }());