Issue 4864 - Start using ESLint for adblockpluschrome

lib/devtools.js

 /*
  * This file is part of Adblock Plus <https://adblockplus.org/>,
- * Copyright (C) 2006-2016 Eyeo GmbH
+ * Copyright (C) 2006-2017 eyeo GmbH
  *
  * Adblock Plus is free software: you can redistribute it and/or modify
  * it under the terms of the GNU General Public License version 3 as
  * published by the Free Software Foundation.
  *
  * Adblock Plus is distributed in the hope that it will be useful,
  * but WITHOUT ANY WARRANTY; without even the implied warranty of
  * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the
  * GNU General Public License for more details.
  *
@@ skipping 63 matching lines @@
 }
 
 function hasRecord(panel, request, filter)
 {
   return panel.records.some(record =>
     record.request.url == request.url &&
     record.request.docDomain == request.docDomain &&
 
     // Ignore partial (e.g. ELEMHIDE) whitelisting if there is already
     // a DOCUMENT exception which disables all means of blocking.
-    (record.request.type == "DOCUMENT"
-     ? nonRequestTypes.indexOf(request.type) != -1
-     : record.request.type == request.type) &&

[Wladimir Palant, 2017/03/14 13:03:27]

Please don't use one-space indentations. Besides, operator is supposed to be
before the line break. So rather something like:

  (
    record.request.type == "DOCUMENT" ?
    nonRequestTypes.indexOf(request.type) != -1 :
    record.request.type == request.type
  ) &&
  ...

[kzar, 2017/03/15 04:57:47]

It turns out we're using the default configuration for the operator-linebreak
rule in our configuration, which makes an exception for the `?` and `:`
operators:

  "after", { "overrides": { "?": "before", ":": "before" } }

That seems like a mistake to me so I've opened a review to fix that
https://codereview.adblockplus.org/29384022/

+    (record.request.type == "DOCUMENT" ?
+       nonRequestTypes.includes(request.type) :
+       record.request.type == request.type) &&
 
     // Matched element hiding filters don't relate to a particular request,
-    // so we also have to match the CSS selector in order to distinguish them.
+    // so we have to compare the selector in order to avoid duplicates.
     (record.filter && record.filter.selector) == (filter && filter.selector)
   );
 }
 
 function addRecord(panel, request, filter)
 {
   if (!hasRecord(panel, request, filter))
   {
     panel.port.postMessage({
       type: "add-record",
@@ skipping 31 matching lines @@
  * @param {?BlockingFilter} filter The matched filter or null if there is no
  *                                 match
  */
 exports.logRequest = function(page, url, type, docDomain,
                               thirdParty, sitekey,
                               specificOnly, filter)
 {
   let panel = getActivePanel(page);
   if (panel)
   {
-    addRecord(panel, {url, type, docDomain, thirdParty, sitekey, specificOnly},
-              filter);
+    let request = {url, type, docDomain, thirdParty, sitekey, specificOnly};
+    addRecord(panel, request, filter);
   }
 };
 
 /**
  * Logs active element hiding filters to the devtools panel.
  *
  * @param {Page}     page       The page the elements were hidden on
  * @param {string[]} selectors  The CSS selectors of active elemhide filters
  * @param {string}   docDomain  The IDN-decoded hostname of the document
  */
@@ skipping 61 matching lines @@
 };
 
 function onBeforeRequest(details)
 {
   let panel = panels[details.tabId];
 
   // Clear the devtools panel and reload the inspected tab without caching
   // when a new request is issued. However, make sure that we don't end up
   // in an infinite recursion if we already triggered a reload.
   if (panel.reloading)
+  {
     panel.reloading = false;
+  }
   else
   {
     panel.records = [];
     panel.port.postMessage({type: "reset"});
 
     // We can't repeat the request if it isn't a GET request. Chrome would
     // prompt the user to confirm reloading the page, and POST requests are
     // known to cause issues on many websites if repeated.
     if (details.method == "GET")
       panel.reload = true;
@@ skipping 137 matching lines @@
   panels[inspectedTabId] = {port: newPort, records: []};
 });
 
 port.on("devtools.traceElemHide", (message, sender) =>
 {
   logHiddenElements(
     sender.page, message.selectors,
     extractHostFromFrame(sender.frame)
   );
 });