Issue 4864 - Start using ESLint for adblockpluschrome

lib/filterValidation.js

 /*
  * This file is part of Adblock Plus <https://adblockplus.org/>,
- * Copyright (C) 2006-2016 Eyeo GmbH
+ * Copyright (C) 2006-2017 eyeo GmbH
  *
  * Adblock Plus is free software: you can redistribute it and/or modify
  * it under the terms of the GNU General Public License version 3 as
  * published by the Free Software Foundation.
  *
  * Adblock Plus is distributed in the hope that it will be useful,
  * but WITHOUT ANY WARRANTY; without even the implied warranty of
  * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the
  * GNU General Public License for more details.
  *
@@ skipping 91 matching lines @@
   }
   catch (e)
   {
     return false;
   }
   return true;
 }
 
 /**
  * @typedef ParsedFilter
- * @property {?Filter} [filter]  The parsed filter if it is valid.
- *                               Or null if the given string is empty.
+ * @property {?Filter} [filter]
+ *   The parsed filter if it is valid. Or null if the given string is empty.
  * @property {FilterParsingError} [error]
- * See {@link module:filterValidation~FilterParsingError FilterParsingError}

[Wladimir Palant, 2017/03/14 13:03:28]

Please indent this line.

[kzar, 2017/03/15 04:57:49]

Done.

+ *   See {@link module:filterValidation~FilterParsingError FilterParsingError}
  */
 
 let parseFilter =
 /**
  * Parses and validates a filter given by the user.
  *
  * @param {string}  text
  * @return {ParsedFilter}
  */
 exports.parseFilter = text =>
@@ skipping 18 matching lines @@
       return {error: new FilterParsingError("invalid-css-selector",
                                             {selector: filter.selector})};
     }
   }
 
   return {filter};
 };
 
 /**
  * @typedef ParsedFilters
- * @property {Filter[]} filters  The parsed result without invalid filters.
+ * @property {Filter[]} filters
+ *   The parsed result without invalid filters.
  * @property {FilterParsingError[]} errors
- * See {@link module:filterValidation~FilterParsingError FilterParsingError}

[Wladimir Palant, 2017/03/14 13:03:27]

Please indent this line.

[kzar, 2017/03/15 04:57:48]

Done.

+ *   See {@link module:filterValidation~FilterParsingError FilterParsingError}
  */
 
 /**
  * Parses and validates a newline-separated list of filters given by the user.
  *
  * @param {string}  text
  * @return {ParsedFilters}
  */
 exports.parseFilters = text =>
 {
@@ skipping 10 matching lines @@
 
     if (error)
     {
       error.lineno = i + 1;
       errors.push(error);
     }
   }
 
   return {filters, errors};
 };