Issue 4864 - Start using ESLint for adblockpluschrome

lib/notificationHelper.js

 /*
  * This file is part of Adblock Plus <https://adblockplus.org/>,
- * Copyright (C) 2006-2016 Eyeo GmbH
+ * Copyright (C) 2006-2017 eyeo GmbH
  *
  * Adblock Plus is free software: you can redistribute it and/or modify
  * it under the terms of the GNU General Public License version 3 as
  * published by the Free Software Foundation.
  *
  * Adblock Plus is distributed in the hope that it will be useful,
  * but WITHOUT ANY WARRANTY; without even the implied warranty of
  * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the
  * GNU General Public License for more details.
  *
@@ skipping 188 matching lines @@
         // We use the highest priority to prevent the notification
         // from closing automatically.
         priority: 2
       });
     }
     else if ("Notification" in window && activeNotification.type != "question")
     {
       if (linkCount > 0)
         message += " " + ext.i18n.getMessage("notification_without_buttons");
 
-      let notif = new Notification(

[Wladimir Palant, 2017/03/14 13:03:28]

I understand that the point here is to avoid masking the notification parameter.
However, this change doesn't really help making this code more obvious. I.e.,
what's the difference between notification and notif variables? How about
indicating this one as a UI element by naming it "widget"?

[kzar, 2017/03/15 04:57:51]

Done.

+      let widget = new Notification(
         title,
         {
           lang: Utils.appLocale,
           dir: ext.i18n.getMessage("@@bidi_dir"),
           body: message,
           icon: iconUrl
         }
       );
 
-      notif.addEventListener("click", openNotificationLinks);
-      notif.addEventListener("close", notificationClosed);
+      widget.addEventListener("click", openNotificationLinks);
+      widget.addEventListener("close", notificationClosed);
     }
     else
     {
       message = title + "\n" + message;
       if (linkCount > 0)
         message += "\n\n" + ext.i18n.getMessage("notification_with_buttons");
 
       let approved = confirm(message);
       if (activeNotification.type == "question")
         notificationButtonClick(approved ? 0 : 1);
@@ skipping 38 matching lines @@
   let methods = displayMethods[notificationType] || defaultDisplayMethods;
   return methods.indexOf(method) > -1;
 };
 
 ext.pages.onLoading.addListener(page =>
 {
   NotificationStorage.showNext(stringifyURL(page.url));
 });
 
 NotificationStorage.addShowListener(showNotification);