Issue 4864 - Start using ESLint for adblockpluschrome

options.js

 /*
  * This file is part of Adblock Plus <https://adblockplus.org/>,
- * Copyright (C) 2006-2016 Eyeo GmbH
+ * Copyright (C) 2006-2017 eyeo GmbH
  *
  * Adblock Plus is free software: you can redistribute it and/or modify
  * it under the terms of the GNU General Public License version 3 as
  * published by the Free Software Foundation.
  *
  * Adblock Plus is distributed in the hope that it will be useful,
  * but WITHOUT ANY WARRANTY; without even the implied warranty of
  * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the
  * GNU General Public License for more details.
  *
@@ skipping 14 matching lines @@
  *                              values as arguments.
  * @return {function} The generated messaging function, optionally
  *                    taking any values as specified by the paramKeys
  *                    and finally an optional callback.  (Although the
  *                    value arguments are optional their index must be
  *                    maintained. E.g. if you omit the first value you
  *                    must omit the second too.)
  */
 function wrapper(baseMessage, ...paramKeys)
 {
   return function(...paramValues /* , callback */)

[Wladimir Palant, 2017/03/14 13:03:30]

I wonder why this isn't using promises. Not something for this review of course.

[kzar, 2017/03/15 04:57:53]

Acknowledged.

   {
     let message = Object.create(null);
     for (let key in baseMessage)
     {
       if (baseMessage.hasOwnProperty(key))
         message[key] = baseMessage[key];
     }
 
     let callback;
 
@@ skipping 313 matching lines @@
 
 function addSubscriptionClicked()
 {
   let list = document.getElementById("subscriptionSelector");
   let data = list.options[list.selectedIndex]._data;
   if (data)
     addSubscription(data.url, data.title, data.homepage);
   else
   {
     let url = document.getElementById("customSubscriptionLocation")
-      .value.trim();

[Wladimir Palant, 2017/03/14 13:03:30]

Nit: align dots maybe?

[kzar, 2017/03/15 04:57:53]

Done.

+                      .value.trim();
     if (!/^https?:/i.test(url))
     {
       alert(i18n.getMessage("global_subscription_invalid_location"));
       $("#customSubscriptionLocation").focus();
       return;
     }
 
     let title = document.getElementById("customSubscriptionTitle").value.trim();
     if (!title)
       title = url;
@@ skipping 225 matching lines @@
   let rawFilters = document.getElementById("rawFilters");
   let filters = [];
 
   if (rawFilters.style.display != "table-row")
   {
     rawFilters.style.display = "table-row";
     for (let option of document.getElementById("userFiltersBox").options)
       filters.push(option.value);
   }
   else
+  {
     rawFilters.style.display = "none";
+  }
 
   document.getElementById("rawFiltersText").value = filters.join("\n");
 }
 
 // Imports filters in the raw text box
 function importRawFiltersText()
 {
   let text = document.getElementById("rawFiltersText").value;
 
   importRawFilters(text, true, errors =>
@@ skipping 108 matching lines @@
       onFilterMessage(message.action, message.args[0]);
       break;
     case "prefs.respond":
       onPrefMessage(message.action, message.args[0]);
       break;
     case "subscriptions.respond":
       onSubscriptionMessage(message.action, message.args[0]);
       break;
   }
 });