Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code

Delta Between Two Patch Sets: notification.js

Issue 29374674: Issue 4864 - Start using ESLint for adblockpluschrome (Closed)
Left Patch Set: Address Sebastian's feedback, don't update adblockpluscore Created March 30, 2017, 7:08 a.m.
Right Patch Set: Use .includes again Created March 31, 2017, 8:37 a.m.
Left:
Right:
Use n/p to move between diff chunks; N/P to move between comments.
Jump to:
Left: Side by side diff | Download
Right: Side by side diff | Download
« no previous file with change/comment | « lib/whitelisting.js ('k') | options.js » ('j') | no next file with change/comment »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
LEFTRIGHT
1 /* 1 /*
2 * This file is part of Adblock Plus <https://adblockplus.org/>, 2 * This file is part of Adblock Plus <https://adblockplus.org/>,
3 * Copyright (C) 2006-2017 eyeo GmbH 3 * Copyright (C) 2006-2017 eyeo GmbH
4 * 4 *
5 * Adblock Plus is free software: you can redistribute it and/or modify 5 * Adblock Plus is free software: you can redistribute it and/or modify
6 * it under the terms of the GNU General Public License version 3 as 6 * it under the terms of the GNU General Public License version 3 as
7 * published by the Free Software Foundation. 7 * published by the Free Software Foundation.
8 * 8 *
9 * Adblock Plus is distributed in the hope that it will be useful, 9 * Adblock Plus is distributed in the hope that it will be useful,
10 * but WITHOUT ANY WARRANTY; without even the implied warranty of 10 * but WITHOUT ANY WARRANTY; without even the implied warranty of
(...skipping 72 matching lines...) Expand 10 before | Expand all | Expand 10 after
83 event.preventDefault(); 83 event.preventDefault();
84 event.stopPropagation(); 84 event.stopPropagation();
85 ext.pages.open(link.href); 85 ext.pages.open(link.href);
86 }); 86 });
87 87
88 let notificationElement = document.getElementById("notification"); 88 let notificationElement = document.getElementById("notification");
89 notificationElement.className = notification.type; 89 notificationElement.className = notification.type;
90 notificationElement.hidden = false; 90 notificationElement.hidden = false;
91 notificationElement.addEventListener("click", event => 91 notificationElement.addEventListener("click", event =>
92 { 92 {
93 switch (event.target.id) 93 if (event.target.id == "notification-close")
94 notificationElement.classList.add("closing");
95 else if (event.target.id == "notification-optout" ||
96 event.target.id == "notification-hide")
94 { 97 {
95 case "notification-close": 98 if (event.target.id == "notification-optout")
96 notificationElement.classList.add("closing");
97 break;
98 case "notification-optout":
99 Notification.toggleIgnoreCategory("*", true); 99 Notification.toggleIgnoreCategory("*", true);
100 // Falls through. 100
Sebastian Noack 2017/03/30 18:57:59 This switch has mere 3 cases. If we discourage fal
kzar 2017/03/31 03:42:20 Done.
101 case "notification-hide": 101 notificationElement.hidden = true;
102 notificationElement.hidden = true; 102 notification.onClicked();
103 notification.onClicked();
104 break;
105 } 103 }
106 }, true); 104 }, true);
107 }, false); 105 }, false);
LEFTRIGHT

Powered by Google App Engine
This is Rietveld