subscriptionLink.postload.js - Issue 29374674: Issue 4864 - Start using ESLint for adblockpluschrome

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Unified Diff: subscriptionLink.postload.js

Issue 29374674: Issue 4864 - Start using ESLint for adblockpluschrome (Closed)

Patch Set: Created Feb. 7, 2017, 4:49 p.m.

Use n/p to move between diff chunks; N/P to move between comments.

Jump to:

Index: subscriptionLink.postload.js

diff --git a/subscriptionLink.postload.js b/subscriptionLink.postload.js

index 0aaf68c78dd12e4f82afa3f37b3138529207893f..9f2fc26b5d3476e15a2e18c94944047e8d6cbf70 100644

--- a/subscriptionLink.postload.js

+++ b/subscriptionLink.postload.js

@@ -45,7 +45,9 @@ if (document instanceof HTMLDocument)

return;

}

else if (!/^abp:\/*subscribe\/*\?/i.test(link.href))

+ {

return;

+ }

// This is our link - make sure the browser doesn't handle it

event.preventDefault();

@@ -84,8 +86,8 @@ if (document instanceof HTMLDocument)

ext.backgroundPage.sendMessage({

type: "subscriptions.add",

- title: title,

- url: url,

+ title,

+ url,

confirm: true

});

}, true);

« no previous file with comments | « stats.js ('k') | utils.js » ('j') | no next file with comments »