Unified Diff: chrome/ext/popup.js
Issue 29374674:
Issue 4864 - Start using ESLint for adblockpluschrome (Closed)
Patch Set: Use var for ext declarations again
Created Feb. 8, 2017, 9:02 a.m.
Use n/p to move between diff chunks;
N/P to move between comments.
« chrome/ext/common.js ('K')
|
« chrome/ext/common.js ('k')
|
composer.js » ('j')
|
composer.js » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')
| Index: chrome/ext/popup.js |
| diff --git a/chrome/ext/popup.js b/chrome/ext/popup.js |
| index f5132aa457a4366129078917064aefc9092ebc42..8e757b066fda40fdc7512f32c0e8d85f3ca67f6f 100644 |
| --- a/chrome/ext/popup.js |
| +++ b/chrome/ext/popup.js |
| @@ -2,7 +2,10 @@ |
| { |
| const backgroundPage = chrome.extension.getBackgroundPage(); |
| + |
| + /* eslint-disable no-var */ |
| var ext = Object.create(backgroundPage.ext); |
|
Sebastian Noack
2017/02/09 01:04:49
The popup code (also) broke because you used Objec
kzar
2017/02/20 10:27:30
Ah well spotted, Done.
|
| + /* eslint-enable no-var */ |
| ext.closePopup = () => |
| { |
« chrome/ext/common.js ('K')
|
« chrome/ext/common.js ('k')
|
composer.js » ('j')
|
composer.js » ('J')
