chrome/ext/popup.js - Issue 29374674: Issue 4864 - Start using ESLint for adblockpluschrome

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Unified Diff: chrome/ext/popup.js

Issue 29374674: Issue 4864 - Start using ESLint for adblockpluschrome (Closed)

Patch Set: Addressed some of Sebastian's feedback, made other improvements Created Feb. 20, 2017, 10:06 a.m.

Use n/p to move between diff chunks; N/P to move between comments.

Jump to:

Index: chrome/ext/popup.js

diff --git a/chrome/ext/popup.js b/chrome/ext/popup.js

index f5132aa457a4366129078917064aefc9092ebc42..7eb1ca45497aeb37cbb9a5a96400a6c791e47ae5 100644

--- a/chrome/ext/popup.js

+++ b/chrome/ext/popup.js

@@ -1,8 +1,10 @@

"use strict";

+let ext;

{

const backgroundPage = chrome.extension.getBackgroundPage();

- var ext = Object.create(backgroundPage.ext);

+ ext = Object.create(backgroundPage.ext);

ext.closePopup = () =>

{

« no previous file with comments | « chrome/ext/common.js ('k') | composer.js » ('j') | no next file with comments »