ext/common.js - Issue 29374674: Issue 4864 - Start using ESLint for adblockpluschrome

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Unified Diff: ext/common.js

Issue 29374674: Issue 4864 - Start using ESLint for adblockpluschrome (Closed)

Patch Set: Fixed typo with shadowRoot getter Created March 14, 2017, 10:28 a.m.

Use n/p to move between diff chunks; N/P to move between comments.

Jump to:

Index: ext/common.js

diff --git a/ext/common.js b/ext/common.js

index 445dc73ad58621eae3adf7a5170a687e093707bd..097c19dc3866d18c1fbcb6f4a1ced0645ac68b6c 100644

--- a/ext/common.js

+++ b/ext/common.js

@@ -17,9 +17,12 @@

"use strict";

- var ext = {};

+/* eslint-disable no-var */

+var ext = {};

+/* eslint-enable no-var */

Wladimir Palant 2017/03/14 13:03:23 Use `window.ext = {}` inside the IIFE instead of d

kzar 2017/03/15 04:57:44 Done.

+(function()

let EventTarget = ext._EventTarget = function()

{

this._listeners = [];

@@ -36,15 +39,15 @@

if (idx != -1)

this._listeners.splice(idx, 1);

- _dispatch()

+ _dispatch(...args)

{

let results = [];

let listeners = this._listeners.slice();

for (let listener of listeners)

- results.push(listener.apply(null, arguments));

+ results.push(listener(...args));

return results;

}

};

+}());