lib/messaging.js - Issue 29374674: Issue 4864 - Start using ESLint for adblockpluschrome

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Unified Diff: lib/messaging.js

Issue 29374674: Issue 4864 - Start using ESLint for adblockpluschrome (Closed)

Patch Set: Fixed typo with shadowRoot getter Created March 14, 2017, 10:28 a.m.

Use n/p to move between diff chunks; N/P to move between comments.

Jump to:

Index: lib/messaging.js

diff --git a/lib/messaging.js b/lib/messaging.js

index 4e8f3237b546fb5bbb9de02b5f8c9ef9438b3d8d..448c15b244e3d1da2f03d9583f1cd580149067f5 100644

--- a/lib/messaging.js

+++ b/lib/messaging.js

@@ -31,7 +31,7 @@ function Port()

this._eventEmitter = new EventEmitter();

this._onMessage = this._onMessage.bind(this);

ext.onMessage.addListener(this._onMessage);

-};

Port.prototype = {

_onMessage(message, sender, sendResponse)

@@ -47,7 +47,8 @@ Port.prototype = {

{

response.then(

sendResponse,

- reason => {

+ reason =>

+ {

console.error(reason);

sendResponse(undefined);

}

@@ -55,9 +56,7 @@ Port.prototype = {

async = true;

}

else if (typeof response != "undefined")

- {

sendResponse(response);

- }

}

return async;