Unified Diff: lib/messaging.js
Issue 29374674:
Issue 4864 - Start using ESLint for adblockpluschrome (Closed)
Patch Set: Addressed Wladimir's feedback
Created March 15, 2017, 4:51 a.m.
Use n/p to move between diff chunks;
N/P to move between comments.
« no previous file with comments
|
« lib/io.js ('k')
|
lib/notificationHelper.js » ('j')
|
no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')
| Index: lib/messaging.js |
| diff --git a/lib/messaging.js b/lib/messaging.js |
| index 4e8f3237b546fb5bbb9de02b5f8c9ef9438b3d8d..448c15b244e3d1da2f03d9583f1cd580149067f5 100644 |
| --- a/lib/messaging.js |
| +++ b/lib/messaging.js |
| @@ -31,7 +31,7 @@ function Port() |
| this._eventEmitter = new EventEmitter(); |
| this._onMessage = this._onMessage.bind(this); |
| ext.onMessage.addListener(this._onMessage); |
| -}; |
| +} |
| Port.prototype = { |
| _onMessage(message, sender, sendResponse) |
| @@ -47,7 +47,8 @@ Port.prototype = { |
| { |
| response.then( |
| sendResponse, |
| - reason => { |
| + reason => |
| + { |
| console.error(reason); |
| sendResponse(undefined); |
| } |
| @@ -55,9 +56,7 @@ Port.prototype = { |
| async = true; |
| } |
| else if (typeof response != "undefined") |
| - { |
| sendResponse(response); |
| - } |
| } |
| return async; |
« no previous file with comments
|
« lib/io.js ('k')
|
lib/notificationHelper.js » ('j')
|
no next file with comments »
