notification.js - Issue 29374674: Issue 4864 - Start using ESLint for adblockpluschrome

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Unified Diff: notification.js

Issue 29374674: Issue 4864 - Start using ESLint for adblockpluschrome (Closed)

Patch Set: Address Sebastian's feedback, don't update adblockpluscore Created March 30, 2017, 7:08 a.m.

Use n/p to move between diff chunks; N/P to move between comments.

Jump to:

Index: notification.js

diff --git a/notification.js b/notification.js

index ea6b43485e15322ecb72631d5a154de7646e0fc4..9f14d7fcf06dc67680bc1c49603434ff4fd45656 100644

--- a/notification.js

+++ b/notification.js

@@ -97,6 +97,7 @@ window.addEventListener("load", () =>

break;

case "notification-optout":

Notification.toggleIgnoreCategory("*", true);

+ // Falls through.

Sebastian Noack 2017/03/30 18:57:59 This switch has mere 3 cases. If we discourage fal

kzar 2017/03/31 03:42:20 Done.

case "notification-hide":

notificationElement.hidden = true;

notification.onClicked();

« lib/devtools.js ('K') | « lib/whitelisting.js ('k') | options.js » ('j') | no next file with comments »