lib/url.js - Issue 29374674: Issue 4864 - Start using ESLint for adblockpluschrome

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Unified Diff: lib/url.js

Issue 29374674: Issue 4864 - Start using ESLint for adblockpluschrome (Closed)

Patch Set: Addressed more feedback Created March 31, 2017, 8:23 a.m.

Use n/p to move between diff chunks; N/P to move between comments.

Jump to:

Index: lib/url.js

diff --git a/lib/url.js b/lib/url.js

index 63782e88a550f0cd4b66a23e606f19ab0c00db2c..36dcf66ad62c24925ddb557a12c5dbe7ea3a817a 100644

--- a/lib/url.js

+++ b/lib/url.js

@@ -32,7 +32,7 @@ let getDecodedHostname =

exports.getDecodedHostname = url =>

{

- let hostname = url.hostname;

+ let {hostname} = url;

if (hostname.indexOf("xn--") == -1)

return hostname;

@@ -69,12 +69,11 @@ exports.extractHostFromFrame = frame =>

exports.stringifyURL = url =>

{

- let protocol = url.protocol;

- let href = url.href;

+ let {protocol, href} = url;

if (protocol == "http:" || protocol == "https:")

{

- let hostname = url.hostname;

+ let {hostname} = url;

if (hostname.indexOf("xn--") != -1)

href = href.replace(hostname, punycode.toUnicode(hostname));

« no previous file with comments | « lib/tldjs.js ('k') | lib/utils.js » ('j') | no next file with comments »