Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(299)

Issue 29374901: Issue 3768 - Check (and fix, if needed) multilocale builds (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
2 years, 11 months ago by diegocarloslima
Modified:
2 years, 9 months ago
Reviewers:
Felix Dahlke, anton
CC:
René Jeschke
Visibility:
Public.

Description

Issue 3768 - Check (and fix, if needed) multilocale builds

Patch Set 1 #

Patch Set 2 : Adding Issue reference #

Total comments: 2
Unified diffs Side-by-side diffs Delta from patch set Stats (+4 lines, -0 lines) Patch
M mozharness/base/vcs/vcsbase.py View 1 1 chunk +4 lines, -0 lines 2 comments Download

Messages

Total messages: 5
diegocarloslima
2 years, 11 months ago (2017-02-09 21:28:07 UTC) #1
anton
On 2017/02/09 21:28:07, diegocarloslima wrote: LGTM
2 years, 11 months ago (2017-02-15 10:57:09 UTC) #2
anton
https://codereview.adblockplus.org/29374901/diff/29374904/mozharness/base/vcs/vcsbase.py File mozharness/base/vcs/vcsbase.py (right): https://codereview.adblockplus.org/29374901/diff/29374904/mozharness/base/vcs/vcsbase.py#newcode80 mozharness/base/vcs/vcsbase.py:80: kwargs['revision'] = kwargs.get('tag') BTW can it be written as ...
2 years, 11 months ago (2017-02-15 11:00:05 UTC) #3
diegocarloslima
https://codereview.adblockplus.org/29374901/diff/29374904/mozharness/base/vcs/vcsbase.py File mozharness/base/vcs/vcsbase.py (right): https://codereview.adblockplus.org/29374901/diff/29374904/mozharness/base/vcs/vcsbase.py#newcode80 mozharness/base/vcs/vcsbase.py:80: kwargs['revision'] = kwargs.get('tag') On 2017/02/15 11:00:05, anton wrote: > ...
2 years, 10 months ago (2017-02-24 19:54:09 UTC) #4
Felix Dahlke
2 years, 10 months ago (2017-02-27 07:43:45 UTC) #5
LGTM
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld 87257f5