Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code

Issue 29375657: Issue 4882 - Adapted deps in tox.ini for flake8-abp to flake8-eyeo renaming (cms) (Closed)

Created:
Feb. 13, 2017, 1:32 p.m. by Sebastian Noack
Modified:
Feb. 13, 2017, 2:45 p.m.
Reviewers:
Jon Sonesen
CC:
Vasily Kuznetsov, kzar
Visibility:
Public.

Description

Issue 4882 - Adapted deps in tox.ini for flake8-abp to flake8-eyeo renaming (cms)

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -1 line) Patch
M tox.ini View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 6
Sebastian Noack
Feb. 13, 2017, 1:35 p.m. (2017-02-13 13:35:36 UTC) #1
Jon Sonesen
On 2017/02/13 13:35:36, Sebastian Noack wrote: LGTM
Feb. 13, 2017, 1:56 p.m. (2017-02-13 13:56:26 UTC) #2
Jon Sonesen
On 2017/02/13 13:35:36, Sebastian Noack wrote: LGTM
Feb. 13, 2017, 1:56 p.m. (2017-02-13 13:56:26 UTC) #3
Jon Sonesen
On 2017/02/13 13:56:26, Jon Sonesen wrote: > On 2017/02/13 13:35:36, Sebastian Noack wrote: > > ...
Feb. 13, 2017, 1:57 p.m. (2017-02-13 13:57:50 UTC) #4
Sebastian Noack
On 2017/02/13 13:57:50, Jon Sonesen wrote: > On 2017/02/13 13:56:26, Jon Sonesen wrote: > > ...
Feb. 13, 2017, 1:59 p.m. (2017-02-13 13:59:04 UTC) #5
Jon Sonesen
Feb. 13, 2017, 2:05 p.m. (2017-02-13 14:05:43 UTC) #6
On 2017/02/13 13:59:04, Sebastian Noack wrote:
> On 2017/02/13 13:57:50, Jon Sonesen wrote:
> > On 2017/02/13 13:56:26, Jon Sonesen wrote:
> > > On 2017/02/13 13:35:36, Sebastian Noack wrote:
> > > 
> > > LGTM
> > 
> > whoops NOT LGTM meant to wait until the rename patch is applied
> 
> Of course I will land all patches in one go. Ultimately, there has to be a
short
> time span in which we have an inconsistent state.

ok LGTM

Powered by Google App Engine
This is Rietveld