Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code

Issue 29375671: Noissue - Fixed new flake8 errors (Closed)

Created:
Feb. 13, 2017, 2:39 p.m. by Sebastian Noack
Modified:
Feb. 13, 2017, 2:55 p.m.
Reviewers:
Jon Sonesen
CC:
kzar, Oleksandr
Visibility:
Public.

Description

Noissue - Fixed new flake8 errors

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -2 lines) Patch
M localeTools.py View 1 chunk +1 line, -1 line 0 comments Download
M packagerEdge.py View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 2
Sebastian Noack
@Dave, Ollie: Please always run flake8 (with flake8-eyeo, previously flake8-abp) on your Python code before ...
Feb. 13, 2017, 2:44 p.m. (2017-02-13 14:44:16 UTC) #1
Jon Sonesen
Feb. 13, 2017, 2:54 p.m. (2017-02-13 14:54:07 UTC) #2
On 2017/02/13 14:44:16, Sebastian Noack wrote:
> @Dave, Ollie: Please always run flake8 (with flake8-eyeo, previously
flake8-abp)
> on your Python code before submitting it for review. These two nits (which
> flake8 complains about now) have been sneaked in during your last changes to
> buildtools, where you apparently didn't care to run flake8 (or tox). The
> recommended way to use flake8 is through tox.

LGTM

Powered by Google App Engine
This is Rietveld