Delta Between Two Patch Sets: templates/default.tmpl
Issue 29375829:
Issue 4899 - set template META description on eyeo.com (Closed)
Left Patch Set: Deleted the include and added to the default template
Created Feb. 28, 2017, 12:34 p.m.
Right Patch Set: Deleted Space and added slash
Created March 8, 2017, 11:06 a.m.
| Left: | ||
| Right: |
Use n/p to move between diff chunks;
N/P to move between comments.
« no previous file with change/comment
|
« no previous file
|
no next file »
|
no next file with change/comment »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')
| LEFT | RIGHT |
|---|---|
| 1 <!DOCTYPE html> | 1 <!DOCTYPE html> |
| 2 <html lang="{{locale}}"> | 2 <html lang="{{locale}}"> |
| 3 <head> | 3 <head> |
| 4 {# HTML5 essentials #} | 4 {# HTML5 essentials #} |
| 5 <meta charset="utf-8"> | 5 <meta charset="UTF-8" /> |
|
saroyanm
2017/02/28 17:24:58
It's uppercase UTF-8 -> https://developer.mozilla.
erick
2017/03/01 11:29:40
Done.
| |
| 6 <meta name="viewport" content="width=device-width,initial-scale=1,maximum-scal e=1,user-scalable=no" /> | 6 <meta name="viewport" content="width=device-width,initial-scale=1,maximum-scal e=1,user-scalable=no" /> |
| 7 <meta http-equiv="X-UA-Compatible" content="IE=edge"> | 7 <meta http-equiv="X-UA-Compatible" content="IE=edge"> |
| 8 | 8 |
| 9 {# HTML5 meta #} | 9 {# HTML5 meta #} |
| 10 <meta name="title" content="{{ title }}" > | 10 {% if description %} |
|
saroyanm
2017/02/28 17:24:58
The title is being specified below, I don't think
erick
2017/03/01 11:29:40
You are right. I thought there is a difference whe
| |
| 11 <meta name="description" content="{{ description if description else 'eyeo fea tures a host of products, all of which are geared toward giving users more contr ol and more information about their online experience.' }}"> | 11 <meta name="description" content="{{ description }}"> |
|
saroyanm
2017/02/28 17:24:58
Why are you using the description below:
"eyeo fea
erick
2017/03/01 11:29:40
It should be used as a placeholder, when there is
| |
| 12 {% endif %} | |
| 12 | 13 |
| 13 {# http://ogp.me/ #} | 14 {# http://ogp.me/ #} |
| 14 <meta property="og:image" content="{{og_image if og_image else 'https://eyeo.c om/images/eyeo-meta-default.png'}}"> | 15 <meta property="og:image" content="{{og_image if og_image else 'https://eyeo.c om/images/eyeo-meta-default.png'}}"> |
| 15 | 16 |
| 16 {% if title %} | 17 {% if title %} |
| 17 <title>{{title}} | eyeo GmbH</title> | 18 <title>{{title}} | eyeo GmbH</title> |
| 18 {% else %} | 19 {% else %} |
| 19 <title>eyeo GmbH</title> | 20 <title>eyeo GmbH</title> |
| 20 {% endif %} | 21 {% endif %} |
| 21 | 22 |
| 22 <link rel="shortcut icon" href="/images/favicon.png" /> | 23 <link rel="shortcut icon" href="/images/favicon.png" /> |
| 23 | 24 |
| 24 <link rel="stylesheet" href="/css/styles.css" type="text/css" media="all"> | 25 <link rel="stylesheet" href="/css/styles.css" type="text/css" media="all"> |
| 25 | 26 |
| (...skipping 69 matching lines...) Expand 10 before | Expand all | Expand 10 after Loading... | |
| 95 </small> | 96 </small> |
| 96 <div id="footer-links"> | 97 <div id="footer-links"> |
| 97 {{"contact"|linkify}}Made with ♥ in Cologne</a> | 98 {{"contact"|linkify}}Made with ♥ in Cologne</a> |
| 98 {{"privacy"|linkify}}Privacy Policy</a> | 99 {{"privacy"|linkify}}Privacy Policy</a> |
| 99 </div> | 100 </div> |
| 100 </div> | 101 </div> |
| 101 </footer> | 102 </footer> |
| 102 </body> | 103 </body> |
| 103 | 104 |
| 104 </html> | 105 </html> |
| LEFT | RIGHT |
« no previous file
|
no next file »
|
Toggle Intra-line Diffs ('i')
|
Expand Comments ('e')
|
Collapse Comments ('c')
|
Toggle Comments ('s')
