Unified Diff: templates/default.tmpl
Issue 29375829:
Issue 4899 - set template META description on eyeo.com (Closed)
Patch Set: Deleted the include and added to the default template
Created Feb. 28, 2017, 12:34 p.m.
Use n/p to move between diff chunks;
N/P to move between comments.
« no previous file with comments
|
« no previous file
|
no next file »
|
no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')
| Index: templates/default.tmpl |
| diff --git a/templates/default.tmpl b/templates/default.tmpl |
| index 9026714b4f9392e1bfc9e7f1f8fd3a0d0e0da63f..0505ecb4755816eaec9b720b86d0acfc3e0c3840 100644 |
| --- a/templates/default.tmpl |
| +++ b/templates/default.tmpl |
| @@ -1,11 +1,18 @@ |
| <!DOCTYPE html> |
| <html lang="{{locale}}"> |
| <head> |
| - <meta charset="UTF-8" /> |
| + {# HTML5 essentials #} |
| + <meta charset="utf-8"> |
|
saroyanm
2017/02/28 17:24:58
It's uppercase UTF-8 -> https://developer.mozilla.
erick
2017/03/01 11:29:40
Done.
|
| <meta name="viewport" content="width=device-width,initial-scale=1,maximum-scale=1,user-scalable=no" /> |
| <meta http-equiv="X-UA-Compatible" content="IE=edge"> |
| - <meta property="og:image" content="{{og_image if og_image else 'https://eyeo.com/images/eyeo-meta-default.png'}}"> |
| + {# HTML5 meta #} |
| + <meta name="title" content="{{ title }}" > |
|
saroyanm
2017/02/28 17:24:58
The title is being specified below, I don't think
erick
2017/03/01 11:29:40
You are right. I thought there is a difference whe
|
| + <meta name="description" content="{{ description if description else 'eyeo features a host of products, all of which are geared toward giving users more control and more information about their online experience.' }}"> |
|
saroyanm
2017/02/28 17:24:58
Why are you using the description below:
"eyeo fea
erick
2017/03/01 11:29:40
It should be used as a placeholder, when there is
|
| + |
| + {# http://ogp.me/ #} |
| + <meta property="og:image" content="{{og_image if og_image else 'https://eyeo.com/images/eyeo-meta-default.png'}}"> |
| + |
| {% if title %} |
| <title>{{title}} | eyeo GmbH</title> |
| {% else %} |
« no previous file with comments
|
« no previous file
|
no next file »
|
no next file with comments »
