metadata.common - Issue 29375851: [safari] Issue 4902 - Partially revert d5be57b68f91 for Safari compatibility

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Delta Between Two Patch Sets: metadata.common

Issue 29375851: [safari] Issue 4902 - Partially revert d5be57b68f91 for Safari compatibility (Closed)

Left Patch Set: Created Feb. 17, 2017, 9:31 a.m.

Right Patch Set: Addressed Sebastian's feedback Created Feb. 17, 2017, 2:16 p.m.

Left:
Right:

Use n/p to move between diff chunks; N/P to move between comments.

Jump to:

Left: Side by side diff | Download
Right: Side by side diff | Download

LEFT	RIGHT
1 [general]	1 [general]

2 version = 1.12.4	2 version = 1.12.4

3 backgroundScripts = lib/polyfills/url.js	3 backgroundScripts = lib/polyfills/url.js

4 lib/polyfills/promise.js	4 lib/polyfills/promise.js

5 lib/polyfills/fetch.js	5 lib/polyfills/fetch.js

6 ext/common.js	6 ext/common.js

7 ext/background.js	7 ext/background.js

8 lib/compat.js	8 lib/compat.js

9 lib/info.js	9 lib/info.js

10 lib/publicSuffixList.js	10 lib/publicSuffixList.js

11 lib/adblockplus.js	11 lib/adblockplus.js

12 lib/sha1.js	12 lib/sha1.js # These three scripts are strictly redundant as their counterparts
Sebastian Noack 2017/02/17 11:59:19 Perhaps, add a comment here, at least, explaining Perhaps, add a comment here, at least, explaining that these scripts are redundant with code in adblockpluscore, but that the code from adblockpluscore is apparently incompatible with Safari, referring to the issue. kzar 2017/02/17 14:17:24 Done. Show quoted text On 2017/02/17 11:59:19, Sebastian Noack wrote: > Perhaps, add a comment here, at least, explaining that these scripts are > redundant with code in adblockpluscore, but that the code from adblockpluscore > is apparently incompatible with Safari, referring to the issue. Done.
13 lib/jsbn.js	13 lib/jsbn.js # now live in adblockpluscore. We've added them back here rather

14 lib/rsa.js	14 lib/rsa.js # than debugging an issue with Safari compatibility. See #4902.

15 messageResponder.js	15 messageResponder.js

16 background.js	16 background.js

17 testScripts = ../ext/common.js	17 testScripts = ../ext/common.js

18 ../ext/background.js	18 ../ext/background.js

19 ../lib/compat.js	19 ../lib/compat.js

20 ../lib/info.js	20 ../lib/info.js

21 ../lib/adblockplus.js	21 ../lib/adblockplus.js

22 ../lib/publicSuffixList.js	22 ../lib/publicSuffixList.js

23 ../lib/sha1.js
Sebastian Noack 2017/02/17 11:59:19 There is no reason to re-add the tests, as they ca There is no reason to re-add the tests, as they cannot run on Safari anyway. kzar 2017/02/17 14:17:24 Done. Show quoted text On 2017/02/17 11:59:19, Sebastian Noack wrote: > There is no reason to re-add the tests, as they cannot run on Safari anyway. Done.
24 ../lib/jsbn.js

25 ../lib/rsa.js

26 common.js	23 common.js

27 tests/prefs.js	24 tests/prefs.js

28 tests/versionComparator.js	25 tests/versionComparator.js

29 tests/url.js	26 tests/url.js

30 tests/signatures.js

31 tests/cssEscaping.js	27 tests/cssEscaping.js

32 permissions = http:/// https:///	28 permissions = http:/// https:///

33 author = Eyeo GmbH	29 author = Eyeo GmbH

34	30

35 [contentScripts]	31 [contentScripts]

36 document_start = ext/common.js ext/content.js cssProperties.js include.preload.j s	32 document_start = ext/common.js ext/content.js cssProperties.js include.preload.j s

37 document_end = include.postload.js	33 document_end = include.postload.js

38	34

39 [mapping]	35 [mapping]

40 cssProperties.js = adblockpluscore/chrome/content/cssProperties.js	36 cssProperties.js = adblockpluscore/chrome/content/cssProperties.js

(...skipping 87 matching lines...) Expand 10 before \| Expand all \| Expand 10 after Loading...
128 addSubscription.label	124 addSubscription.label

129 addSubscriptionAdd.label	125 addSubscriptionAdd.label

130 addSubscriptionOther.label	126 addSubscriptionOther.label

131 acceptableAds2.label	127 acceptableAds2.label

132 viewList.label	128 viewList.label

133 readMore.label	129 readMore.label

134 adblockplus/chrome/locale/*/subscriptionSelection.dtd = location.label	130 adblockplus/chrome/locale/*/subscriptionSelection.dtd = location.label

135 title.label	131 title.label

136 adblockplus/chrome/locale/*/meta.properties = =name	132 adblockplus/chrome/locale/*/meta.properties = =name

137 adblockplusui/locale//firstRun.json = =	133 adblockplusui/locale//firstRun.json = =

LEFT	RIGHT