Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code

Issue 29375891: [adblockplus] Issue 4928 - No longer call ElemHideEmulation.load (Closed)

Created:
Feb. 18, 2017, 11:18 a.m. by wspee
Modified:
May 21, 2017, 8:33 p.m.
Visibility:
Public.

Description

[adblockplus] No longer call ElemHideEmulation.load See https://codereview.adblockplus.org/29370970/

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -1 line) Patch
M lib/child/elemHideEmulation.js View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 4
wspee
Feb. 18, 2017, 11:21 a.m. (2017-02-18 11:21:11 UTC) #1
Sebastian Noack
The changes look good. But ideally the same commit would update the adblocpkluscore dependency as ...
Feb. 18, 2017, 11:29 a.m. (2017-02-18 11:29:45 UTC) #2
wspee
On 2017/02/18 11:29:45, Sebastian Noack wrote: > The changes look good. But ideally the same ...
Feb. 18, 2017, 12:47 p.m. (2017-02-18 12:47:46 UTC) #3
Wladimir Palant
March 29, 2017, 1:15 p.m. (2017-03-29 13:15:00 UTC) #4
I'm closing this review since it is redundant given
https://issues.adblockplus.org/ticket/5055.

Powered by Google App Engine
This is Rietveld