Side by Side Diff: README.md
Issue 29375899:
Issue 4871 - Start using ESLint for adblockplusui (Closed)
Patch Set: Fix regressions with the new options page
Created March 1, 2017, 8:25 a.m.
| Left: | ||
| Right: |
Use n/p to move between diff chunks;
N/P to move between comments.
« no previous file with comments
|
« .eslintrc.json ('k')
|
background.js » ('j')
|
background.js » ('J')
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')
| OLD | NEW |
|---|---|
| 1 Shared Adblock Plus UI code | 1 Shared Adblock Plus UI code |
| 2 =========================== | 2 =========================== |
| 3 | 3 |
| 4 The user interface elements defined in this repository will be used by various | 4 The user interface elements defined in this repository will be used by various |
| 5 Adblock Plus products like Adblock Plus for Firefox. Their functionality can be | 5 Adblock Plus products like Adblock Plus for Firefox. Their functionality can be |
| 6 tested within this repository, even though they might not work exactly the same | 6 tested within this repository, even though they might not work exactly the same |
| 7 as they will do in the final product. | 7 as they will do in the final product. |
| 8 | 8 |
| 9 Directory structure | 9 Directory structure |
| 10 ------------------- | 10 ------------------- |
| (...skipping 76 matching lines...) Expand 10 before | Expand all | Expand 10 after Loading... | |
| 87 errors when adding new filters on the options page | 87 errors when adding new filters on the options page |
| 88 * `blockedURLs`: a comma-separated list of URLs that should be considered | 88 * `blockedURLs`: a comma-separated list of URLs that should be considered |
| 89 blocked (necessary to test the check for blocked scripts in sharing buttons). | 89 blocked (necessary to test the check for blocked scripts in sharing buttons). |
| 90 * `downloadStatus`: sets downloadStatus parameter for filter lists, can be used | 90 * `downloadStatus`: sets downloadStatus parameter for filter lists, can be used |
| 91 to trigger various filter list download errors | 91 to trigger various filter list download errors |
| 92 * `platform=chromium`: shows the opt-out for the developer tools panel | 92 * `platform=chromium`: shows the opt-out for the developer tools panel |
| 93 * `showNotificationUI=true`: simulates user having opted-out of notifications | 93 * `showNotificationUI=true`: simulates user having opted-out of notifications |
| 94 | 94 |
| 95 | 95 |
| 96 [crowdin]: https://crowdin.com | 96 [crowdin]: https://crowdin.com |
| 97 | |
| 98 Linting | |
| 99 ------- | |
| 100 | |
| 101 You can lint the code using [ESLint](http://eslint.org). | |
| 102 | |
| 103 eslint *.js lib ext | |
|
Thomas Greiner
2017/03/01 17:39:32
This is only useful with a config file so we shoul
kzar
2017/03/02 04:36:01
Not required since the ESLint configuration in thi
Thomas Greiner
2017/03/07 13:33:00
Right, nevermind then.
| |
| 104 | |
| 105 You will need to set up ESLint and our configuration first, see | |
| 106 [eslint-config-eyeo](https://hg.adblockplus.org/codingtools/file/tip/eslint-conf ig-eyeo) | |
| 107 for more information. | |
| OLD | NEW |
« no previous file with comments
|
« .eslintrc.json ('k')
|
background.js » ('j')
|
background.js » ('J')
