Issue 4871 - Start using ESLint for adblockplusui

ext/background.js

 /*
  * This file is part of Adblock Plus <https://adblockplus.org/>,
  * Copyright (C) 2006-2016 Eyeo GmbH
  *
  * Adblock Plus is free software: you can redistribute it and/or modify
  * it under the terms of the GNU General Public License version 3 as
  * published by the Free Software Foundation.
  *
  * Adblock Plus is distributed in the hope that it will be useful,
  * but WITHOUT ANY WARRANTY; without even the implied warranty of
  * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the
  * GNU General Public License for more details.
  *
  * You should have received a copy of the GNU General Public License
  * along with Adblock Plus.  If not, see <http://www.gnu.org/licenses/>.
  */
 
-(function(global)
+"use strict";
+
 {
-  if (!global.ext)
-    global.ext = {};
+  if (typeof ext == "undefined")
+    window.ext = {};
 
-  window.addEventListener("load", function()
+  window.addEventListener("load", () =>
   {
     parent.postMessage({
       type: "backgroundPageLoaded"
     }, "*");
-  }, false)
+  }, false);
 
   function PageMap()

[Wladimir Palant, 2017/03/09 15:05:06]

Same here, please switch back to IIFE.

[kzar, 2017/03/10 07:28:58]

Done.

   {
     this._keys = [];
     this._values = [];
   }
   PageMap.prototype = {
-    keys: function()
+    keys()
     {
-      return this._keys.map(function(source)
+      return this._keys.map((source) =>
       {
-        return new global.ext.Page(source);
+        return new window.ext.Page(source);
       });
     },
 
-    get: function(page)
+    get(page)
     {
       return this._values[this._keys.indexOf(page._source)];
     },
 
-    set: function(page, value)
+    set(page, value)
     {
-      var index = this._keys.indexOf(page._source);
+      let index = this._keys.indexOf(page._source);
       if (index < 0)
       {
         index = this._keys.push(page._source) - 1;
 
-        var callback = function()
+        let callback = function()
         {
           page._source.removeEventListener("unload", callback, false);
           this.delete(page);
         }.bind(this);
         page._source.addEventListener("unload", callback, false);
       }
       this._values[index] = value;
     },
 
-    delete: function(page)
+    delete(page)
     {
-      var index = this._keys.indexOf(page._source);
+      let index = this._keys.indexOf(page._source);
       if (index >= 0)
       {
         this._keys.splice(index, 1);
         this._values.splice(index, 1);
       }
     }
   };
 
-  global.ext.PageMap = PageMap;
+  window.ext.PageMap = PageMap;
 
-  global.ext.showOptions = function(callback)
+  window.ext.showOptions = function(callback)
   {
     if (top.location.href.indexOf("new-options.html") == -1)
       window.open("new-options.html", "_blank");
 
     if (callback)
       callback();
   };
 
-  global.ext.devtools = {
+  window.ext.devtools = {
     onCreated: {
-      addListener: function(listener)
+      addListener(listener)
       {
-        window.addEventListener("message", function(event)
+        window.addEventListener("message", (event) =>
         {
           if (event.data.type == "devtools")
             listener(new ext.Page(event.source));
         });
       }
     }
   };
-})(this);
+}