Issue 4871 - Start using ESLint for adblockplusui

firstRun.js

 /*
  * This file is part of Adblock Plus <https://adblockplus.org/>,
  * Copyright (C) 2006-2016 Eyeo GmbH
  *
  * Adblock Plus is free software: you can redistribute it and/or modify
  * it under the terms of the GNU General Public License version 3 as
  * published by the Free Software Foundation.
  *
  * Adblock Plus is distributed in the hope that it will be useful,
  * but WITHOUT ANY WARRANTY; without even the implied warranty of
  * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the
  * GNU General Public License for more details.
  *
  * You should have received a copy of the GNU General Public License
  * along with Adblock Plus.  If not, see <http://www.gnu.org/licenses/>.
  */
 
+/* globals checkShareResource, getDocLink, openSharePopup, E */
+
 "use strict";
 
-(function()
 {
   function onDOMLoaded()

[Wladimir Palant, 2017/03/09 15:05:08]

As with other files, this won't work without IIFE.

[kzar, 2017/03/10 07:28:59]

Done.

   {
     // Set up logo image
-    var logo = E("logo");
+    let logo = E("logo");
     logo.src = "skin/abp-128.png";
-    var errorCallback = function()
+    let errorCallback = function()
     {
       logo.removeEventListener("error", errorCallback, false);
       // We are probably in Chrome/Opera/Safari, the image has a different path.
       logo.src = "icons/detailed/abp-128.png";
     };
     logo.addEventListener("error", errorCallback, false);
 
     // Set up URLs
-    getDocLink("donate", function(link)
+    getDocLink("donate", (link) =>
     {
       E("donate").href = link;
     });
 
-    getDocLink("contributors", function(link)
+    getDocLink("contributors", (link) =>
     {
       E("contributors").href = link;
     });
 
-    getDocLink("acceptable_ads_criteria", function(link)
+    getDocLink("acceptable_ads_criteria", (link) =>
     {
       setLinks("acceptable-ads-explanation", link, openFilters);
     });
 
-    getDocLink("contribute", function(link)
+    getDocLink("contribute", (link) =>
     {
       setLinks("share-headline", link);
     });
 
     ext.backgroundPage.sendMessage({
       type: "app.get",
       what: "issues"
-    }, function(issues)
+    }, (issues) =>
     {
       // Show warning if filterlists settings were reinitialized
       if (issues.filterlistsReinitialized)
       {
         E("filterlistsReinitializedWarning").removeAttribute("hidden");
         setLinks("filterlistsReinitializedWarning", openFilters);
       }
     });
 
     updateSocialLinks();
 
-    ext.onMessage.addListener(function(message)
+    ext.onMessage.addListener((message) =>
     {
       if (message.type == "subscriptions.respond")
       {
         updateSocialLinks();
       }
     });
     ext.backgroundPage.sendMessage({
       type: "subscriptions.listen",
       filter: ["added", "removed", "updated", "disabled"]
     });
   }
 
   function updateSocialLinks()
   {
-    var networks = ["twitter", "facebook", "gplus"];
-    networks.forEach(function(network)
+    for (let network of ["twitter", "facebook", "gplus"])
     {
-      var link = E("share-" + network);
-      checkShareResource(link.getAttribute("data-script"), function(isBlocked)
+      let link = E("share-" + network);
+      checkShareResource(link.getAttribute("data-script"), (isBlocked) =>
       {
         // Don't open the share page if the sharing script would be blocked
         if (isBlocked)
           link.removeEventListener("click", onSocialLinkClick, false);
         else
           link.addEventListener("click", onSocialLinkClick, false);
       });
-    });
+    }
   }
 
   function onSocialLinkClick(event)
   {
     if (window.matchMedia("(max-width: 970px)").matches)
       return;
 
     event.preventDefault();
 
-    getDocLink(event.target.id, function(link)
+    getDocLink(event.target.id, (link) =>
     {
       openSharePopup(link);
     });
   }
 
-  function setLinks(id)
+  function setLinks(id, ...args)
   {
-    var element = E(id);
+    let element = E(id);
     if (!element)
     {
       return;
     }
 
-    var links = element.getElementsByTagName("a");
+    let links = element.getElementsByTagName("a");
 
-    for (var i = 0; i < links.length; i++)
+    for (let i = 0; i < links.length; i++)
     {
-      if (typeof arguments[i + 1] == "string")
+      if (typeof args[i] == "string")
       {
-        links[i].href = arguments[i + 1];
+        links[i].href = args[i];
         links[i].setAttribute("target", "_blank");
       }
-      else if (typeof arguments[i + 1] == "function")
+      else if (typeof args[i] == "function")
       {
         links[i].href = "javascript:void(0);";
-        links[i].addEventListener("click", arguments[i + 1], false);
+        links[i].addEventListener("click", args[i], false);
       }
     }
   }
 
   function openFilters()
   {
     ext.backgroundPage.sendMessage({type: "app.open", what: "options"});
   }
 
   document.addEventListener("DOMContentLoaded", onDOMLoaded, false);
-})();
+}