Side by Side Diff
Use n/p to move between diff chunks; N/P to move between comments.
Keyboard Shortcuts
File
u
:
up to issue
m
:
publish + mail comments
M
:
edit review message
j
/
k
:
jump to file after / before current file
J
/
K
:
jump to next file with a comment after / before current file
Side-by-side diff
i
:
toggle intra-line diffs
e
:
expand all comments
c
:
collapse all comments
s
:
toggle showing all comments
n
/
p
:
next / previous diff chunk or comment
N
/
P
:
next / previous comment
<Up>
/
<Down>
:
next / previous line
<Enter>
:
respond to / edit current comment
d
:
mark current comment as done
Issue
u
:
up to list of issues
m
:
publish + mail comments
j
/
k
:
jump to patch after / before current patch
o
/
<Enter>
:
open current patch in side-by-side view
i
:
open current patch in unified diff view
Issue List
j
/
k
:
jump to issue after / before current issue
o
/
<Enter>
:
open current issue
#
:
close issue
Comment/message editing
<Ctrl>
+
s
or
<Ctrl>
+
Enter
:
save comment
<Esc>
:
cancel edit
Rietveld
Code Review Tool
Help
|
Bug tracker
|
Discussion group
|
Source code
Issues
All Issues
Side by Side Diff: .eslintrc.json
Issue
29375899
:
Issue 4871 - Start using ESLint for adblockplusui (Closed)
Patch Set: Avoid violating operator-linebreak rule
Created March 15, 2017, 4:43 a.m.
Left:
Base
Patch Set 1: None
Patch Set 2: Stop using commonjs, fix other problems
Patch Set 3: Started addressing Sebastian's initial feedback
Patch Set 4: Addressed the rest of Sebastian's feedback
Patch Set 5: Fix regressions with the new options page
Patch Set 6: Addressed Thomas' feedback
Patch Set 7: Rebased.
Patch Set 8: Move dots to the start of the line
Patch Set 9: Remove the arrow-parens rule
Patch Set 10: Addressed Wladimir's feedback, restored IIFEs
Patch Set 11: Rebased.
Patch Set 12: Fix imports in antiadblockInit.js
Patch Set 13: Removed unused import
Patch Set 14: Avoid violating operator-linebreak rule
Right:
Patch Set 1: None
Patch Set 2: Stop using commonjs, fix other problems
Patch Set 3: Started addressing Sebastian's initial feedback
Patch Set 4: Addressed the rest of Sebastian's feedback
Patch Set 5: Fix regressions with the new options page
Patch Set 6: Addressed Thomas' feedback
Patch Set 7: Rebased.
Patch Set 8: Move dots to the start of the line
Patch Set 9: Remove the arrow-parens rule
Patch Set 10: Addressed Wladimir's feedback, restored IIFEs
Patch Set 11: Rebased.
Patch Set 12: Fix imports in antiadblockInit.js
Patch Set 13: Removed unused import
Patch Set 14: Avoid violating operator-linebreak rule
Use n/p to move between diff chunks; N/P to move between comments.
Jump to:
.eslintrc.json
README.md
background.js
common.js
devtools-panel.js
ext/background.js
ext/common.js
ext/content.js
ext/devtools.js
firstRun.js
i18n.js
lib/.eslintrc.json
lib/antiadblockInit.js
messageResponder.js
new-options.js
View unified diff
|
Download patch
« no previous file with comments
|
« no previous file
|
README.md »
('j') |
no next file with comments »
Toggle Intra-line Diffs
('i') |
Expand Comments
('e') |
Collapse Comments
('c') |
Show Comments
Hide Comments
('s')
OLD
NEW
(Empty)
1
{
2
"extends": "eslint-config-eyeo",
3
"root": true,
4
"env": {
5
"browser": true,
6
"webextensions": true
7
},
8
"globals": {
9
"ext": true
10
}
11
}
OLD
NEW
« no previous file with comments
|
« no previous file
|
README.md »
('j') |
no next file with comments »
Edit Message
Issue 29375899: Issue 4871 - Start using ESLint for adblockplusui (Closed)
Created Feb. 20, 2017, 10:01 a.m. by kzar
Modified March 16, 2017, 10:50 a.m.
Reviewers: Thomas Greiner, Wladimir Palant
Base URL:
Comments: 82
+ 2 drafts
This is Rietveld