Issue 4871 - Start using ESLint for adblockplusui

common.js

 /*
  * This file is part of Adblock Plus <https://adblockplus.org/>,
  * Copyright (C) 2006-2016 Eyeo GmbH
  *
  * Adblock Plus is free software: you can redistribute it and/or modify
  * it under the terms of the GNU General Public License version 3 as
  * published by the Free Software Foundation.
  *
  * Adblock Plus is distributed in the hope that it will be useful,
  * but WITHOUT ANY WARRANTY; without even the implied warranty of
  * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the
  * GNU General Public License for more details.
  *
  * You should have received a copy of the GNU General Public License
  * along with Adblock Plus.  If not, see <http://www.gnu.org/licenses/>.
  */
 
-/* globals Components, E */
+/* globals Components */
 
 "use strict";
 
-window.E = function E(id)
+function E(id)
 {
   return document.getElementById(id);
-};
+}
 
-window.getDocLink = function(link, callback)
+function getDocLink(link, callback)
 {
   ext.backgroundPage.sendMessage({
     type: "app.get",
     what: "doclink",
     link
   }, callback);
-};
+}
 
-window.checkShareResource = function(url, callback)
+function checkShareResource(url, callback)
 {
   ext.backgroundPage.sendMessage({
     type: "filters.blocked",
     url,
     requestType: "SCRIPT",
     docDomain: "adblockplus.org",
     thirdParty: true
   }, callback);
-};
+}
 
-window.openSharePopup = function(url)
+function openSharePopup(url)
 {
   let glassPane = E("glass-pane");
   if (!glassPane)
   {
     glassPane = document.createElement("div");
     glassPane.setAttribute("id", "glass-pane");
     document.body.appendChild(glassPane);
   }
 
   let iframe = E("share-popup");
@@ skipping 86 matching lines @@
       glassPane.className = "";
       window.removeEventListener("message", popupMessageListener);
     }
 
     iframe.removeEventListener("load", popupLoadListener);
   };
   iframe.addEventListener("load", popupLoadListener, false);
 
   iframe.src = url;
   glassPane.className = "visible";
-};
+}