Issue 4871 - Start using ESLint for adblockplusui

ext/common.js

 /*
  * This file is part of Adblock Plus <https://adblockplus.org/>,
  * Copyright (C) 2006-2016 Eyeo GmbH
  *
  * Adblock Plus is free software: you can redistribute it and/or modify
  * it under the terms of the GNU General Public License version 3 as
  * published by the Free Software Foundation.
  *
  * Adblock Plus is distributed in the hope that it will be useful,
  * but WITHOUT ANY WARRANTY; without even the implied warranty of
  * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the
  * GNU General Public License for more details.
  *
  * You should have received a copy of the GNU General Public License
  * along with Adblock Plus.  If not, see <http://www.gnu.org/licenses/>.
  */
 
 "use strict";
 
+(function()
 {
   if (typeof ext == "undefined")
     window.ext = {};
 
   function Page(source)
   {
     this._source = source;
   }
   Page.prototype =
   {
@@ skipping 79 matching lines @@
     return catalog;
   };
 
   let selectedLocale = window.navigator.language;
   let match = /[?&]locale=([\w-]+)/.exec(window.location.search);
   if (match)
     selectedLocale = match[1];
 
   let locales = getLocaleCandidates(selectedLocale);
   let catalog = initCatalog(locales[0]);
-  let catalogFile = window.location.pathname.replace(/.*\//, "").
-    replace(/\..*/, "") + ".json";
+  let catalogFile = window.location.pathname.replace(/.*\//, "")
+    .replace(/\..*/, "") + ".json";
 
   let replacePlaceholder = function(text, placeholder, content)
   {
     return text.split("$" + placeholder + "$").join(content || "");
   };
 
   let parseMessage = function(rawMessage)
   {
     let text = rawMessage.message;
     let placeholders = [];
@@ skipping 33 matching lines @@
     for (let msgId in rawCatalog)
     {
       if (!(msgId in catalog))
         catalog[msgId] = parseMessage(rawCatalog[msgId]);
     }
   };
 
   window.ext.i18n = {
     getMessage(msgId, substitutions)
     {
-      /* eslint-disable no-constant-condition */

[Sebastian Noack, 2017/02/21 12:21:20]

As discussed in the changes for adblockpluscore, we should rather remove this
rule.

[kzar, 2017/02/23 11:10:22]

Done.

       while (true)
       {
         let message = catalog[msgId];
         if (message)
         {
           let text = message[0];
           let placeholders = message[1];
 
           if (!(substitutions instanceof Array))
             substitutions = [substitutions];
 
           for (let i = 0; i < placeholders.length; i++)
             text = replacePlaceholder(text, placeholders[i], substitutions[i]);
 
           return text;
         }
 
         if (locales.length == 0)
           return "";
 
         let locale = locales.shift();
         readCatalog(locale, "common.json");
         readCatalog(locale, catalogFile);
       }
-      /* eslint-enable no-constant-condition */
-    }
-  };
-}
+    }
+  };
+}());