.eslintrc.json - Issue 29375899: Issue 4871 - Start using ESLint for adblockplusui

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Delta Between Two Patch Sets: .eslintrc.json

Issue 29375899: Issue 4871 - Start using ESLint for adblockplusui (Closed)

Left Patch Set: Remove the arrow-parens rule Created March 9, 2017, 10:29 a.m.

Right Patch Set: Avoid violating operator-linebreak rule Created March 15, 2017, 4:43 a.m.

Left:
Right:

Use n/p to move between diff chunks; N/P to move between comments.

Jump to:

Left: Side by side diff | Download
Right: Side by side diff | Download

LEFT	RIGHT
1 {	1 {

2 "extends": "eslint-config-eyeo",	2 "extends": "eslint-config-eyeo",

3 "root": true,	3 "root": true,

4 "env": {	4 "env": {

5 "browser": true,	5 "browser": true,

6 "webextensions": true	6 "webextensions": true

7 },	7 },

8 "globals": {	8 "globals": {

9 "exports": true,	9 "ext": true

10 "ext": true,

11 "require": true
Wladimir Palant 2017/03/09 15:05:06 The way I see it, exports and require are mostly l The way I see it, exports and require are mostly listed here for adblockplusInit.js which is actually a proper CommonJS module. I'd suggest adding .eslintrc.json to the lib/ directory and declare env: { commonjs: true} there. As to require, this is also used by messageResponder.js which is a special case that could run in both environments. I'd declare require as a global explicitly in this file only to indicate that. No other files can/should used exports and require so these globals shouldn't be defined for the entire repository. kzar 2017/03/10 07:28:58 Done. Show quoted text On 2017/03/09 15:05:06, Wladimir Palant wrote: > The way I see it, exports and require are mostly listed here for > adblockplusInit.js which is actually a proper CommonJS module. I'd suggest > adding .eslintrc.json to the lib/ directory and declare env: { commonjs: true} > there. > > As to require, this is also used by messageResponder.js which is a special case > that could run in both environments. I'd declare require as a global explicitly > in this file only to indicate that. > > No other files can/should used exports and require so these globals shouldn't be > defined for the entire repository. Done.
12 }	10 }

13 }	11 }

LEFT	RIGHT