Issue 4871 - Start using ESLint for adblockplusui

background.js

 /*
  * This file is part of Adblock Plus <https://adblockplus.org/>,
  * Copyright (C) 2006-2016 Eyeo GmbH
  *
  * Adblock Plus is free software: you can redistribute it and/or modify
  * it under the terms of the GNU General Public License version 3 as
  * published by the Free Software Foundation.
  *
  * Adblock Plus is distributed in the hope that it will be useful,
  * but WITHOUT ANY WARRANTY; without even the implied warranty of
  * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the
  * GNU General Public License for more details.
  *
  * You should have received a copy of the GNU General Public License
  * along with Adblock Plus.  If not, see <http://www.gnu.org/licenses/>.
  */
 
 "use strict";
 
+(function()
 {
   function EventEmitter()

[Wladimir Palant, 2017/03/09 15:05:06]

Please revert to IIFE here - functions should not be declared in the block
scope. This code will throw in strict mode at least in Firefox, and EventEmitter
will still be declared globally despite the block.

[kzar, 2017/03/10 07:28:58]

Done.

But unless I missed something passing window as a parameter to the IIFE was
pointless, so I didn't revert that part.

[Wladimir Palant, 2017/03/14 11:14:57]

Not strictly necessary here, it was merely there to avoid assumptions about the
execution context. These files always run in window context, messageResponder
doesn't.

[kzar, 2017/03/15 03:16:57]

Acknowledged.

   {
     this._listeners = Object.create(null);
   }
   EventEmitter.prototype = {
     on(name, listener)
     {
       if (name in this._listeners)
         this._listeners[name].push(listener);
       else
         this._listeners[name] = [listener];
@@ skipping 506 matching lines @@
         docDomain: "example.com"
       },
       filter: {
         text: "||example.com/some-annoying-popup$popup",
         whitelisted: false,
         userDefined: true,
         subscription: null
       }
     });
   });
-}
+}());