Issue 4871 - Start using ESLint for adblockplusui

ext/common.js

 /*
  * This file is part of Adblock Plus <https://adblockplus.org/>,
  * Copyright (C) 2006-2016 Eyeo GmbH
  *
  * Adblock Plus is free software: you can redistribute it and/or modify
  * it under the terms of the GNU General Public License version 3 as
  * published by the Free Software Foundation.
  *
  * Adblock Plus is distributed in the hope that it will be useful,
  * but WITHOUT ANY WARRANTY; without even the implied warranty of
  * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the
  * GNU General Public License for more details.
  *
  * You should have received a copy of the GNU General Public License
  * along with Adblock Plus.  If not, see <http://www.gnu.org/licenses/>.
  */
 
 "use strict";
 
+(function()
 {
   if (typeof ext == "undefined")
     window.ext = {};
 
   function Page(source)

[Wladimir Palant, 2017/03/09 15:05:07]

As with other files, please revert to IIFE.

[kzar, 2017/03/10 07:28:59]

Done.

   {
     this._source = source;
   }
   Page.prototype =
   {
     sendMessage(message)
     {
       this._source.postMessage({
         type: "message",
         messageId: -1,
@@ skipping 155 matching lines @@
 
         if (locales.length == 0)
           return "";
 
         let locale = locales.shift();
         readCatalog(locale, "common.json");
         readCatalog(locale, catalogFile);
       }
     }
   };
-}
+}());