Issue 4871 - Start using ESLint for adblockplusui

lib/antiadblockInit.js

 /*
  * This file is part of Adblock Plus <https://adblockplus.org/>,
  * Copyright (C) 2006-2016 Eyeo GmbH
  *
  * Adblock Plus is free software: you can redistribute it and/or modify
  * it under the terms of the GNU General Public License version 3 as
  * published by the Free Software Foundation.
  *
  * Adblock Plus is distributed in the hope that it will be useful,
  * but WITHOUT ANY WARRANTY; without even the implied warranty of
  * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the
  * GNU General Public License for more details.
  *
  * You should have received a copy of the GNU General Public License
  * along with Adblock Plus.  If not, see <http://www.gnu.org/licenses/>.
  */
 
 "use strict";
-
-const {Services} = Cu.import("resource://gre/modules/Services.jsm", {});

[kzar, 2017/03/14 10:57:36]

I just noticed this gives me a no-unused-vars error. I wonder why we import
Services here if we're not using it?

[Wladimir Palant, 2017/03/14 11:14:57]

This seems to be a left-over, even though I don't see why a previous incarnation
of this code would need Services. Feel free to remove it.

[kzar, 2017/03/15 03:16:58]

Done.

 
 const {Prefs} = require("prefs");
 const {ActiveFilter} = require("filterClasses");
 const {FilterStorage} = require("filterStorage");
 const {FilterNotifier} = require("filterNotifier");
 const {Subscription} = require("subscriptionClasses");
 const {Notification} = require("notification");
 
 let ext;
 if (typeof window != "undefined" && window.ext)
@@ skipping 60 matching lines @@
     if (url in FilterStorage.knownSubscriptions && !subscription.disabled)
       addAntiAdblockNotification(subscription);
     else
       removeAntiAdblockNotification();
   }
 
   FilterNotifier.on("subscription.updated", onSubscriptionChange);
   FilterNotifier.on("subscription.removed", onSubscriptionChange);
   FilterNotifier.on("subscription.disabled", onSubscriptionChange);
 };