README.md - Issue 29375915: Issue 4878 - Start using ESLint for adblockpluscore

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments.

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Side by Side Diff: README.md

Issue 29375915: Issue 4878 - Start using ESLint for adblockpluscore (Closed)

Patch Set: Stop using commonjs, fix other problems Created Feb. 21, 2017, 5:12 a.m.

Left:
Right:

Use n/p to move between diff chunks; N/P to move between comments.

Jump to:

View unified diff | Download patch

OLD	NEW
1 Adblock Plus core	1 Adblock Plus core

2 =================	2 =================

3	3

4 This repository contains the generic Adblock Plus code that's shared between	4 This repository contains the generic Adblock Plus code that's shared between

5 platforms. This repository is not designed to be used directly, but instead to	5 platforms. This repository is not designed to be used directly, but instead to

6 serve as a dependency for `adblockplus`, `adblockpluschrome` and	6 serve as a dependency for `adblockplus`, `adblockpluschrome` and

7 `libadblockplus`.	7 `libadblockplus`.

8	8

9 Running the unit tests	9 Running the unit tests

10 ----------------------	10 ----------------------

(...skipping 13 matching lines...) Expand all Loading...
24	24

25 You can specify specific test files or directories on the command line, e.g.:	25 You can specify specific test files or directories on the command line, e.g.:

26 `npm test test/synchronizer.js test/browser/elemHideEmulation.html`.	26 `npm test test/synchronizer.js test/browser/elemHideEmulation.html`.

27	27

28 ### Running the browser tests in a real browser	28 ### Running the browser tests in a real browser

29	29

30 The tests under `test/browser` require a browser environment. `npm test` will	30 The tests under `test/browser` require a browser environment. `npm test` will

31 run these in a headless browser, but you can also run them in a real one by	31 run these in a headless browser, but you can also run them in a real one by

32 opening	32 opening

33 [test/browser/elemHideEmulation.html](test/browser/elemHideEmulation.html).	33 [test/browser/elemHideEmulation.html](test/browser/elemHideEmulation.html).

	34

	35 Linting

	36 -------

	37

	38 You can lint the code using [ESLint](http://eslint.org).

	39

	40 eslint *.js chrome lib test

	41

	42 You will need to set up ESLint and our configuration first, see

	43 [eslint-config-eyeo](https://hg.adblockplus.org/codingtools/file/tip/eslint-conf ig-eyeo)

	44 for more information.

OLD	NEW

« no previous file with comments | « .eslintrc.json ('k') | lib/coreUtils.js » ('j') | no next file with comments »