Issue 4878 - Start using ESLint for adblockpluscore

test/notification.js

 /*
  * This file is part of Adblock Plus <https://adblockplus.org/>,
  * Copyright (C) 2006-2016 Eyeo GmbH
  *
  * Adblock Plus is free software: you can redistribute it and/or modify
  * it under the terms of the GNU General Public License version 3 as
  * published by the Free Software Foundation.
  *
  * Adblock Plus is distributed in the hope that it will be useful,
  * but WITHOUT ANY WARRANTY; without even the implied warranty of
  * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the
  * GNU General Public License for more details.
  *
  * You should have received a copy of the GNU General Public License
  * along with Adblock Plus.  If not, see <http://www.gnu.org/licenses/>.
  */
 
 "use strict";
 
 let {
   createSandbox, setupTimerAndXMLHttp, setupRandomResult, unexpectedError, Cr
 } = require("./_common");
 
-let info = null;
 let Prefs = null;
 let Notification = null;
 
 exports.setUp = function(callback)
 {
   // Inject our Array and JSON to make sure that instanceof checks on arrays
   // within the sandbox succeed even with data passed in from outside.
   let globals = Object.assign({Array, JSON},
     setupTimerAndXMLHttp.call(this), setupRandomResult.call(this));
 
   let sandboxedRequire = createSandbox({globals});
   (
-    info = sandboxedRequire("./stub-modules/info"),
     {Prefs} = sandboxedRequire("./stub-modules/prefs"),
     {Notification} = sandboxedRequire("../lib/notification")
   );
 
   callback();
 };
 
 function showNotifications(url)
 {
   let shownNotifications = [];
   function showListener(notification)
   {
     shownNotifications.push(notification);
     Notification.markAsShown(notification.id);
   }
   Notification.addShowListener(showListener);
   Notification.showNext(url);
   Notification.removeShowListener(showListener);
   return shownNotifications;
 }
 
 function* pairs(array)
 {
   for (let element1 of array)
+  {
     for (let element2 of array)
+    {
       if (element1 != element2)
         yield [element1, element2];
+    }
+  }
 }
 
 function registerHandler(notifications, checkCallback)
 {
   this.registerHandler("/notification.json", metadata =>
   {
     if (checkCallback)
       checkCallback(metadata);
 
     let notification = {
@@ skipping 90 matching lines @@
   ["platform", "chromium", true],
   ["platform", "gecko", false],
   ["platformMinVersion", "12.0", true],
   ["platformMinVersion", "12", true],
   ["platformMinVersion", "11", true],
   ["platformMinVersion", "13", false],
   ["platformMinVersion", "12.1", false],
   ["platformMaxVersion", "12.0", true],
   ["platformMaxVersion", "12", true],
   ["platformMaxVersion", "13", true],
-  ["platformMaxVersion", "11", false],
+  ["platformMaxVersion", "11", false]
 ])
 {
   exports.testTargetSelection[`${propName}=${value}`] = function(test)
   {
     let targetInfo = {};
     targetInfo[propName] = value;
 
     let information = {
       id: 1,
       type: "information",
@@ skipping 18 matching lines @@
   ["extension", "adblockplus", false],
   ["extensionMinVersion", "1.4", true],
   ["extensionMinVersion", "1.5", false],
   ["application", "chrome", true],
   ["application", "firefox", false],
   ["applicationMinVersion", "27", true],
   ["applicationMinVersion", "28", false],
   ["platform", "chromium", true],
   ["platform", "gecko", false],
   ["platformMinVersion", "12", true],
-  ["platformMinVersion", "13", false],
+  ["platformMinVersion", "13", false]
 ]))
 {
   exports.testMultipleTargets[`${propName1}=${value1},${propName2}=${value2}`] = function(test)
   {
     let targetInfo1 = {};
     targetInfo1[propName1] = value1;
     let targetInfo2 = {};
     targetInfo2[propName2] = value2;
 
     let information = {
       id: 1,
       type: "information",
       message: {"en-US": "Information"},
       targets: [targetInfo1, targetInfo2]
     };
 
     registerHandler.call(this, [information]);
     this.runScheduledTasks(1).then(() =>
     {
-      let expected = (result1 || result2 ? [information] : [])
+      let expected = (result1 || result2 ? [information] : []);
       test.deepEqual(showNotifications(), expected, "Selected notification for " + JSON.stringify(information.targets));
     }).catch(unexpectedError.bind(test)).then(() => test.done());
-  }
+  };
 }
 
 exports.testParametersSent = function(test)
 {
   Prefs.notificationdata = {
     data: {
       version: "3"
-    },
+    }
   };
 
   let parameters = null;
-  registerHandler.call(this, [], function(metadata)
+  registerHandler.call(this, [], metadata =>
   {
     parameters = decodeURI(metadata.queryString);
   });
   this.runScheduledTasks(1).then(() =>
   {
     test.equal(parameters,
           "addonName=adblockpluschrome&addonVersion=1.4.1&application=chrome&applicationVersion=27.0&platform=chromium&platformVersion=12.0&lastVersion=3&downloadCount=0",
           "The correct parameters are sent to the server");
   }).catch(unexpectedError.bind(test)).then(() => test.done());
 };
@@ skipping 68 matching lines @@
     test.ok(!("severity" in notification), "Severity property was removed");
     test.ok("type" in notification, "Type property was added");
     test.equal(notification.type, severityNotification.severity, "Type property has correct value");
     test.done();
   }
   Prefs.addListener(listener);
 
   let responseText = JSON.stringify({
     notifications: [severityNotification]
   });
-  Notification._onDownloadSuccess({}, responseText, function() {}, function() {});
+  Notification._onDownloadSuccess({}, responseText, () => {}, () => {});
 };
 
 exports.testURLSpecificNotification = function(test)
 {
   let withURLFilterFoo = {
     id: 1,
     urlFilters: ["foo.com$document"]
   };
   let withoutURLFilter = {
     id: 2
@@ skipping 149 matching lines @@
   let notification = {message: {fr: "fr"}};
   let texts = Notification.getLocalizedTexts(notification, "fr");
   test.equal(texts.message, "fr");
   texts = Notification.getLocalizedTexts(notification, "fr-CA");
   test.equal(texts.message, "fr");
   test.done();
 };
 
 exports.testLanguageAndCountry = function(test)
 {
-  let notification = {message: {fr: "fr", "fr-CA": "fr-CA"}};
+  let notification = {message: {"fr": "fr", "fr-CA": "fr-CA"}};
   let texts = Notification.getLocalizedTexts(notification, "fr-CA");
   test.equal(texts.message, "fr-CA");
   texts = Notification.getLocalizedTexts(notification, "fr");
   test.equal(texts.message, "fr");
   test.done();
 };
 
 exports.testMissingTranslation = function(test)
 {
   let notification = {message: {"en-US": "en-US"}};
   let texts = Notification.getLocalizedTexts(notification, "fr");
   test.equal(texts.message, "en-US");
   test.done();
 };