Issue 4878 - Start using ESLint for adblockpluscore

test/matcher.js

 /*
  * This file is part of Adblock Plus <https://adblockplus.org/>,
  * Copyright (C) 2006-2016 Eyeo GmbH
  *
  * Adblock Plus is free software: you can redistribute it and/or modify
  * it under the terms of the GNU General Public License version 3 as
  * published by the Free Software Foundation.
  *
  * Adblock Plus is distributed in the hope that it will be useful,
  * but WITHOUT ANY WARRANTY; without even the implied warranty of
  * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the
  * GNU General Public License for more details.
  *
  * You should have received a copy of the GNU General Public License
  * along with Adblock Plus.  If not, see <http://www.gnu.org/licenses/>.
  */
 
 "use strict";
 
-let {createSandbox} = require("./_common");
+const {createSandbox} = require("./_common");
 
 let Filter = null;
 let RegExpFilter = null;
 let CombinedMatcher = null;
 let defaultMatcher = null;
 let Matcher = null;
 
 exports.setUp = function(callback)
 {
   let sandboxedRequire = createSandbox();
   (
     {Filter, RegExpFilter} = sandboxedRequire("../lib/filterClasses"),
     {CombinedMatcher, defaultMatcher, Matcher} = sandboxedRequire("../lib/matcher")
   );
 
   callback();
 };
 
 function compareKeywords(test, text, expected)
 {
   for (let filter of [Filter.fromText(text), Filter.fromText("@@" + text)])
   {
     let matcher = new Matcher();
     let result = [];
-    for (let dummy of expected)
+    for (let i = 0; i < expected.length; i++)
     {
       let keyword = matcher.findKeyword(filter);
       result.push(keyword);
       if (keyword)
       {
-        let dummyFilter = Filter.fromText('^' + keyword + '^');
+        let dummyFilter = Filter.fromText("^" + keyword + "^");
         dummyFilter.filterCount = Infinity;
         matcher.add(dummyFilter);
       }
     }
 
     test.equal(result.join(", "), expected.join(", "), "Keyword candidates for " + filter.text);
   }
 }
 
 function checkMatch(test, filters, location, contentType, docDomain, thirdParty, sitekey, specificOnly, expected)
 {
   let matcher = new Matcher();
   for (let filter of filters)
     matcher.add(Filter.fromText(filter));
 
   let result = matcher.matchesAny(location, RegExpFilter.typeMap[contentType], docDomain, thirdParty, sitekey, specificOnly);
   if (result)
     result = result.text;
 
   test.equal(result, expected, "match(" + location + ", " + contentType + ", " + docDomain + ", " + (thirdParty ? "third-party" : "first-party") + ", " + (sitekey || "no-sitekey") + ", " + (specificOnly ? "specificOnly" : "not-specificOnly") + ") with:\n" + filters.join("\n"));
 
   let combinedMatcher = new CombinedMatcher();
   for (let i = 0; i < 2; i++)
   {
     for (let filter of filters)
       combinedMatcher.add(Filter.fromText(filter));
 
-    let result = combinedMatcher.matchesAny(location, RegExpFilter.typeMap[contentType], docDomain, thirdParty, sitekey, specificOnly);
+    result = combinedMatcher.matchesAny(location, RegExpFilter.typeMap[contentType], docDomain, thirdParty, sitekey, specificOnly);
     if (result)
       result = result.text;
 
     test.equal(result, expected, "combinedMatch(" + location + ", " + contentType + ", " + docDomain + ", " + (thirdParty ? "third-party" : "first-party") + ", " + (sitekey || "no-sitekey") + ", " + (specificOnly ? "specificOnly" : "not-specificOnly") + ") with:\n" + filters.join("\n"));
 
     // Generic whitelisting rules can match for specificOnly searches, so we
     // can't easily know which rule will match for these whitelisting tests
     if (specificOnly)
       continue;
 
@@ skipping 149 matching lines @@
   cacheCheck(test, matcher, "http://fed", "IMAGE", null, true, "http://fed$third-party");
   cacheCheck(test, matcher, "http://abc_cba", "MEDIA", null, false, "cba$~third-party,~script");
   cacheCheck(test, matcher, "http://abc_cba", "MEDIA", null, true, "cba$third-party");
   cacheCheck(test, matcher, "http://abc_cba", "SCRIPT", null, false, "abc$script");
   cacheCheck(test, matcher, "http://def?http://fed", "MEDIA", null, false, "http://fed$~third-party,~script");
   cacheCheck(test, matcher, "http://def?http://fed", "MEDIA", null, true, "http://fed$third-party");
   cacheCheck(test, matcher, "http://def?http://fed", "SCRIPT", null, false, "http://def$script");
 
   test.done();
 };