Side by Side Diff: README.md
Issue 29375915:
Issue 4878 - Start using ESLint for adblockpluscore (Closed)
Patch Set: Rebased.
Created Feb. 28, 2017, 3:55 p.m.
| Left: | ||
| Right: |
Use n/p to move between diff chunks;
N/P to move between comments.
« .eslintrc.json ('K')
|
« .eslintrc.json ('k')
|
lib/common.js » ('j')
|
lib/downloader.js » ('J')
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')
| OLD | NEW |
|---|---|
| 1 Adblock Plus core | 1 Adblock Plus core |
| 2 ================= | 2 ================= |
| 3 | 3 |
| 4 This repository contains the generic Adblock Plus code that's shared between | 4 This repository contains the generic Adblock Plus code that's shared between |
| 5 platforms. This repository is not designed to be used directly, but instead to | 5 platforms. This repository is not designed to be used directly, but instead to |
| 6 serve as a dependency for `adblockplus`, `adblockpluschrome` and | 6 serve as a dependency for `adblockplus`, `adblockpluschrome` and |
| 7 `libadblockplus`. | 7 `libadblockplus`. |
| 8 | 8 |
| 9 Running the unit tests | 9 Running the unit tests |
| 10 ---------------------- | 10 ---------------------- |
| (...skipping 13 matching lines...) Expand all Loading... | |
| 24 | 24 |
| 25 You can specify specific test files or directories on the command line, e.g.: | 25 You can specify specific test files or directories on the command line, e.g.: |
| 26 `npm test test/synchronizer.js test/browser/elemHideEmulation.html`. | 26 `npm test test/synchronizer.js test/browser/elemHideEmulation.html`. |
| 27 | 27 |
| 28 ### Running the browser tests in a real browser | 28 ### Running the browser tests in a real browser |
| 29 | 29 |
| 30 The tests under `test/browser` require a browser environment. `npm test` will | 30 The tests under `test/browser` require a browser environment. `npm test` will |
| 31 run these in a headless browser, with each module being loaded in a new frame. | 31 run these in a headless browser, with each module being loaded in a new frame. |
| 32 *Note*: Currently this environment is limited to ECMAScript 5, this limitation | 32 *Note*: Currently this environment is limited to ECMAScript 5, this limitation |
| 33 should hopefully be resolved soon. | 33 should hopefully be resolved soon. |
| 34 | |
| 35 Linting | |
| 36 ------- | |
| 37 | |
| 38 You can lint the code using [ESLint](http://eslint.org). | |
| 39 | |
| 40 eslint *.js chrome lib test | |
| 41 | |
| 42 You will need to set up ESLint and our configuration first, see | |
| 43 [eslint-config-eyeo](https://hg.adblockplus.org/codingtools/file/tip/eslint-conf ig-eyeo) | |
| 44 for more information. | |
| OLD | NEW |
