Issue 4878 - Start using ESLint for adblockpluscore

test/subscriptionClasses.js

 /*
  * This file is part of Adblock Plus <https://adblockplus.org/>,
  * Copyright (C) 2006-2016 Eyeo GmbH
  *
  * Adblock Plus is free software: you can redistribute it and/or modify
  * it under the terms of the GNU General Public License version 3 as
  * published by the Free Software Foundation.
  *
  * Adblock Plus is distributed in the hope that it will be useful,
  * but WITHOUT ANY WARRANTY; without even the implied warranty of
  * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the
  * GNU General Public License for more details.
  *
  * You should have received a copy of the GNU General Public License
  * along with Adblock Plus.  If not, see <http://www.gnu.org/licenses/>.
  */
 
 "use strict";
 
-let {createSandbox} = require("./_common");
+const {createSandbox} = require("./_common");
 
 let Subscription = null;
 let SpecialSubscription = null;
 let DownloadableSubscription = null;
 let RegularSubscription = null;
 let ExternalSubscription = null;
 
 exports.setUp = function(callback)
 {
   let sandboxedRequire = createSandbox();
@@ skipping 34 matching lines @@
   test.equal(typeof ExternalSubscription, "function", "typeof ExternalSubscription");
   test.equal(typeof DownloadableSubscription, "function", "typeof DownloadableSubscription");
 
   test.done();
 };
 
 exports.testSubscriptionsWithState = function(test)
 {
   compareSubscription(test, "~fl~", ["url=~fl~"]);
   compareSubscription(test, "http://test/default", ["url=http://test/default", "title=http://test/default"]);
-  compareSubscription(test, "http://test/default_titled", ["url=http://test/default_titled", "title=test"], function(subscription)
-  {
-    subscription.title = "test";
-  });
-  compareSubscription(test, "http://test/non_default", ["url=http://test/non_default", "title=test",
-                                                  "disabled=true", "lastSuccess=8", "lastDownload=12", "lastCheck=16", "softExpiration=18", "expires=20", "downloadStatus=foo",
-                                                  "errors=3", "version=24", "requiredVersion=0.6"], function(subscription)
-  {
-    subscription.title = "test";
-    subscription.disabled = true;
-    subscription.lastSuccess = 8;
-    subscription.lastDownload = 12;
-    subscription.lastCheck = 16;
-    subscription.softExpiration = 18;
-    subscription.expires = 20;
-    subscription.downloadStatus = "foo";
-    subscription.errors = 3;
-    subscription.version = 24;
-    subscription.requiredVersion = "0.6";
-  });
-  compareSubscription(test, "~wl~", ["url=~wl~", "disabled=true", "title=Test group"], function(subscription)
-  {
-    subscription.title = "Test group";
-    subscription.disabled = true;
-  });
+  compareSubscription(
+    test, "http://test/default_titled", ["url=http://test/default_titled", "title=test"],
+    subscription =>
+    {
+      subscription.title = "test";
+    }
+  );
+  compareSubscription(
+    test, "http://test/non_default",
+    ["url=http://test/non_default", "title=test", "disabled=true",
+     "lastSuccess=8", "lastDownload=12", "lastCheck=16", "softExpiration=18",
+     "expires=20", "downloadStatus=foo", "errors=3", "version=24",
+     "requiredVersion=0.6"],

[Wladimir Palant, 2017/03/02 14:07:09]

Please don't do one space indentations, these are too hard to recognize.
Instead:

   [
     ...
   ]

[kzar, 2017/03/08 12:33:57]

Done.

+    subscription =>
+    {
+      subscription.title = "test";
+      subscription.disabled = true;
+      subscription.lastSuccess = 8;
+      subscription.lastDownload = 12;
+      subscription.lastCheck = 16;
+      subscription.softExpiration = 18;
+      subscription.expires = 20;
+      subscription.downloadStatus = "foo";
+      subscription.errors = 3;
+      subscription.version = 24;
+      subscription.requiredVersion = "0.6";
+    }
+  );
+  compareSubscription(
+    test, "~wl~", ["url=~wl~", "disabled=true", "title=Test group"],
+    subscription =>
+    {
+      subscription.title = "Test group";
+      subscription.disabled = true;
+    }
+  );
 
   test.done();
 };