Issue 4878 - Start using ESLint for adblockpluscore

test/synchronizer.js

 /*
  * This file is part of Adblock Plus <https://adblockplus.org/>,
  * Copyright (C) 2006-2016 Eyeo GmbH
  *
  * Adblock Plus is free software: you can redistribute it and/or modify
  * it under the terms of the GNU General Public License version 3 as
  * published by the Free Software Foundation.
  *
  * Adblock Plus is distributed in the hope that it will be useful,
  * but WITHOUT ANY WARRANTY; without even the implied warranty of
  * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the
  * GNU General Public License for more details.
  *
  * You should have received a copy of the GNU General Public License
  * along with Adblock Plus.  If not, see <http://www.gnu.org/licenses/>.
  */
 
 "use strict";
 
 let {
   createSandbox, setupTimerAndXMLHttp, setupRandomResult, unexpectedError, Cr,
   MILLIS_IN_SECOND, MILLIS_IN_HOUR
 } = require("./_common");
 
 let Filter = null;
 let FilterStorage = null;
 let Prefs = null;
 let Subscription = null;
-let Synchronizer = null;
 
 exports.setUp = function(callback)
 {
   let globals = Object.assign({}, setupTimerAndXMLHttp.call(this),
     setupRandomResult.call(this));
 
   let sandboxedRequire = createSandbox({globals});
   (
     {Filter} = sandboxedRequire("../lib/filterClasses"),
     {FilterStorage} = sandboxedRequire("../lib/filterStorage"),
     {Prefs} = sandboxedRequire("./stub-modules/prefs"),
     {Subscription} = sandboxedRequire("../lib/subscriptionClasses"),
-    {Synchronizer} = sandboxedRequire("../lib/synchronizer")
+    sandboxedRequire("../lib/synchronizer")
   );
 
   callback();
 };
 
 function resetSubscription(subscription)
 {
   FilterStorage.updateSubscriptionFilters(subscription, []);
-  subscription.lastCheck =  subscription.lastDownload =
+  subscription.lastCheck = subscription.lastDownload =
     subscription.version = subscription.lastSuccess =
     subscription.expires = subscription.softExpiration = 0;
   subscription.title = "";
   subscription.homepage = null;
   subscription.errors = 0;
   subscription.downloadStatus = null;
   subscription.requiredVersion = null;
 }
 
 let initialDelay = 1 / 60;
 
 exports.testOneSubscriptionDownloads = function(test)
 {
   let subscription = Subscription.fromURL("http://example.com/subscription");
   FilterStorage.addSubscription(subscription);
 
   let requests = [];
   this.registerHandler("/subscription", metadata =>
   {
     requests.push([this.getTimeOffset(), metadata.method, metadata.path]);
     return [Cr.NS_OK, 200, "[Adblock]\n! ExPiREs: 1day\nfoo\nbar"];
   });
 
   this.runScheduledTasks(50).then(() =>
   {
     test.deepEqual(requests, [
       [0 + initialDelay, "GET", "/subscription"],
       [24 + initialDelay, "GET", "/subscription"],
-      [48 + initialDelay, "GET", "/subscription"],
+      [48 + initialDelay, "GET", "/subscription"]
     ], "Requests after 50 hours");
   }).catch(unexpectedError.bind(test)).then(() => test.done());
 };
 
 exports.testTwoSubscriptionsDownloads = function(test)
 {
   let subscription1 = Subscription.fromURL("http://example.com/subscription1");
   FilterStorage.addSubscription(subscription1);
 
   let subscription2 = Subscription.fromURL("http://example.com/subscription2");
@@ skipping 13 matching lines @@
   this.registerHandler("/subscription2", handler);
 
   this.runScheduledTasks(55).then(() =>
   {
     test.deepEqual(requests, [
       [0 + initialDelay, "GET", "/subscription1"],
       [2 + initialDelay, "GET", "/subscription2"],
       [24 + initialDelay, "GET", "/subscription1"],
       [26 + initialDelay, "GET", "/subscription2"],
       [48 + initialDelay, "GET", "/subscription1"],
-      [50 + initialDelay, "GET", "/subscription2"],
+      [50 + initialDelay, "GET", "/subscription2"]
     ], "Requests after 55 hours");
   }).catch(unexpectedError.bind(test)).then(() => test.done());
 };
 
 exports.testSubscriptionHeaders = {};
 
 for (let currentTest of [
   {header: "[Adblock]", downloadStatus: "synchronize_ok", requiredVersion: null},
   {header: "[Adblock Plus]", downloadStatus: "synchronize_ok", requiredVersion: null},
   {header: "(something)[Adblock]", downloadStatus: "synchronize_ok", requiredVersion: null},
@@ skipping 16 matching lines @@
     {
       test.equal(subscription.downloadStatus, currentTest.downloadStatus, "Download status");
       test.equal(subscription.requiredVersion, currentTest.requiredVersion, "Required version");
 
       if (currentTest.downloadStatus == "synchronize_ok")
       {
         test.deepEqual(subscription.filters, [
           Filter.fromText("foo"),
           Filter.fromText("!bar"),
           Filter.fromText("@@bas"),
-          Filter.fromText("#bam"),
+          Filter.fromText("#bam")
         ], "Resulting subscription filters");
       }
       else
       {
         test.deepEqual(subscription.filters, [
         ], "Resulting subscription filters");
       }
     }).catch(unexpectedError.bind(test)).then(() => test.done());
   };
 }
 
-exports.testsDisabledUpdates  = function(test)
+exports.testsDisabledUpdates = function(test)
 {
   Prefs.subscriptions_autoupdate = false;
 
   let subscription = Subscription.fromURL("http://example.com/subscription");
   FilterStorage.addSubscription(subscription);
 
   let requests = 0;
   this.registerHandler("/subscription", metadata =>
   {
     requests++;
     throw new Error("Unexpected request");
   });
 
   this.runScheduledTasks(50).then(() =>
   {
     test.equal(requests, 0, "Request count");
   }).catch(unexpectedError.bind(test)).then(() => test.done());
 };
 
 exports.testExpirationTime = {};
 
 for (let currentTest of [
   {
     expiration: "default",
     randomResult: 0.5,
-    requests: [0 + initialDelay, 5 * 24 +  initialDelay]
+    requests: [0 + initialDelay, 5 * 24 + initialDelay]
   },
   {
     expiration: "1 hours",  // Minimal expiration interval
     randomResult: 0.5,
     requests: [0 + initialDelay, 1 + initialDelay, 2 + initialDelay, 3 + initialDelay]
   },
   {
     expiration: "26 hours",
     randomResult: 0.5,
     requests: [0 + initialDelay, 26 + initialDelay]
@@ skipping 80 matching lines @@
   ["Wrong checksum", "[Adblock]\n! Checksum: wrongggny6Fn24b7JHsq/A\nfoo\nbar\n", false],
   ["Empty lines ignored", "[Adblock]\n! Checksum: e/JCmqXny6Fn24b7JHsq/A\n\nfoo\n\nbar\n\n", true],
   ["CR LF line breaks treated like LR", "[Adblock]\n! Checksum: e/JCmqXny6Fn24b7JHsq/A\nfoo\r\nbar\r\n", true],
   ["CR line breaks treated like LR", "[Adblock]\n! Checksum: e/JCmqXny6Fn24b7JHsq/A\nfoo\rbar\r", true],
   ["Trailing line break not ignored", "[Adblock]\n! Checksum: e/JCmqXny6Fn24b7JHsq/A\nfoo\nbar", false],
   ["Line breaks between lines not ignored", "[Adblock]\n! Checksum: e/JCmqXny6Fn24b7JHsq/A\nfoobar", false],
   ["Lines with spaces not ignored", "[Adblock]\n! Checksum: e/JCmqXny6Fn24b7JHsq/A\n \nfoo\n\nbar\n", false],
   ["Extra content in checksum line is part of the checksum", "[Adblock]\n! Checksum: e/JCmqXny6Fn24b7JHsq/A foobar\nfoo\nbar\n", false],
   ["= symbols after checksum are ignored", "[Adblock]\n! Checksum: e/JCmqXny6Fn24b7JHsq/A===\nfoo\nbar\n", true],
   ["Header line is part of the checksum", "[Adblock Plus]\n! Checksum: e/JCmqXny6Fn24b7JHsq/A\nfoo\nbar\n", false],
-  ["Special comments are part of the checksum", "[Adblock]\n! Checksum: e/JCmqXny6Fn24b7JHsq/A\n! Expires: 1\nfoo\nbar\n", false],
+  ["Special comments are part of the checksum", "[Adblock]\n! Checksum: e/JCmqXny6Fn24b7JHsq/A\n! Expires: 1\nfoo\nbar\n", false]
 ])
 {
   exports.testChecksumVerification[testName] = function(test)
   {
     let subscription = Subscription.fromURL("http://example.com/subscription");
     FilterStorage.addSubscription(subscription);
 
     this.registerHandler("/subscription", metadata =>
     {
       return [Cr.NS_OK, 200, subscriptionBody];
@@ skipping 11 matching lines @@
 for (let [comment, check] of [
   ["! Homepage: http://example.com/", (test, subscription) =>
   {
     test.equal(subscription.homepage, "http://example.com/", "Valid homepage comment");
   }],
   ["! Homepage: ssh://example.com/", (test, subscription) =>
   {
     test.equal(subscription.homepage, null, "Invalid homepage comment");
   }],
   ["! Title: foo", (test, subscription) =>
-    {
-      test.equal(subscription.title, "foo", "Title comment");
-      test.equal(subscription.fixedTitle, true, "Fixed title");
-    }],
+  {
+    test.equal(subscription.title, "foo", "Title comment");
+    test.equal(subscription.fixedTitle, true, "Fixed title");
+  }],
   ["! Version: 1234", (test, subscription) =>
   {
     test.equal(subscription.version, 1234, "Version comment");
   }]
 ])
 {
   exports.testSpecialComments[comment] = function(test)
   {
     let subscription = Subscription.fromURL("http://example.com/subscription");
     FilterStorage.addSubscription(subscription);
@@ skipping 40 matching lines @@
     resetSubscription(subscription);
     return this.runScheduledTasks(15);
   }).then(() =>
   {
     test.equal(FilterStorage.subscriptions[0].url, "http://example.com/redirected", "Redirect followed");
     test.deepEqual(requests, [0 + initialDelay, 8 + initialDelay], "Resulting requests");
 
     this.registerHandler("/redirected", metadata =>
     {
       return [Cr.NS_OK, 200, "[Adblock]\nfoo\n!Redirect: http://example.com/subscription\nbar"];
-    })
+    });
 
     subscription = Subscription.fromURL("http://example.com/subscription");
     resetSubscription(subscription);
     FilterStorage.removeSubscription(FilterStorage.subscriptions[0]);
     FilterStorage.addSubscription(subscription);
 
     return this.runScheduledTasks(2);
   }).then(() =>
   {
     test.equal(FilterStorage.subscriptions[0], subscription, "Redirect not followed on redirect loop");
@@ skipping 124 matching lines @@
 
   this.registerHandler("/subscription", metadata =>
   {
     return [Cr.NS_OK, 200, "[Adblock]\n! Expires: 2 hours\nfoo\nbar"];
   });
 
   let startTime = this.currentTime;
   this.runScheduledTasks(2).then(() =>
   {
     test.equal(subscription.downloadStatus, "synchronize_ok", "downloadStatus after successful download");
-    test.equal(subscription.lastDownload * MILLIS_IN_SECOND, startTime +  initialDelay * MILLIS_IN_HOUR, "lastDownload after successful download");
-    test.equal(subscription.lastSuccess * MILLIS_IN_SECOND, startTime +  initialDelay * MILLIS_IN_HOUR, "lastSuccess after successful download");
-    test.equal(subscription.lastCheck * MILLIS_IN_SECOND, startTime + (1 +  initialDelay) * MILLIS_IN_HOUR, "lastCheck after successful download");
+    test.equal(subscription.lastDownload * MILLIS_IN_SECOND, startTime + initialDelay * MILLIS_IN_HOUR, "lastDownload after successful download");
+    test.equal(subscription.lastSuccess * MILLIS_IN_SECOND, startTime + initialDelay * MILLIS_IN_HOUR, "lastSuccess after successful download");
+    test.equal(subscription.lastCheck * MILLIS_IN_SECOND, startTime + (1 + initialDelay) * MILLIS_IN_HOUR, "lastCheck after successful download");
     test.equal(subscription.errors, 0, "errors after successful download");
 
     this.registerHandler("/subscription", metadata =>
     {
       return [Cr.NS_ERROR_FAILURE, 0, ""];
     });
 
     return this.runScheduledTasks(2);
   }).then(() =>
   {
     test.equal(subscription.downloadStatus, "synchronize_connection_error", "downloadStatus after connection error");
-    test.equal(subscription.lastDownload * MILLIS_IN_SECOND, startTime + (2 +  initialDelay) * MILLIS_IN_HOUR, "lastDownload after connection error");
+    test.equal(subscription.lastDownload * MILLIS_IN_SECOND, startTime + (2 + initialDelay) * MILLIS_IN_HOUR, "lastDownload after connection error");
     test.equal(subscription.lastSuccess * MILLIS_IN_SECOND, startTime + initialDelay * MILLIS_IN_HOUR, "lastSuccess after connection error");
     test.equal(subscription.lastCheck * MILLIS_IN_SECOND, startTime + (3 + initialDelay) * MILLIS_IN_HOUR, "lastCheck after connection error");
     test.equal(subscription.errors, 1, "errors after connection error");
 
     this.registerHandler("/subscription", metadata =>
     {
       return [Cr.NS_OK, 404, ""];
     });
 
     return this.runScheduledTasks(24);
   }).then(() =>
   {
     test.equal(subscription.downloadStatus, "synchronize_connection_error", "downloadStatus after download error");
     test.equal(subscription.lastDownload * MILLIS_IN_SECOND, startTime + (26 + initialDelay) * MILLIS_IN_HOUR, "lastDownload after download error");
     test.equal(subscription.lastSuccess * MILLIS_IN_SECOND, startTime + initialDelay * MILLIS_IN_HOUR, "lastSuccess after download error");
     test.equal(subscription.lastCheck * MILLIS_IN_SECOND, startTime + (27 + initialDelay) * MILLIS_IN_HOUR, "lastCheck after download error");
     test.equal(subscription.errors, 2, "errors after download error");
   }).catch(unexpectedError.bind(test)).then(() => test.done());
 };