.eslintignore - Issue 29375915: Issue 4878 - Start using ESLint for adblockpluscore

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Delta Between Two Patch Sets: .eslintignore

Issue 29375915: Issue 4878 - Start using ESLint for adblockpluscore (Closed)

Left Patch Set: Created Feb. 20, 2017, 10:02 a.m.

Right Patch Set: Removed unused imports Created March 15, 2017, 3:11 a.m.

Left:
Right:

Use n/p to move between diff chunks; N/P to move between comments.

Jump to:

Left: Side by side diff | Download
Right: Side by side diff | Download

LEFT	RIGHT
1 lib/jsbn.js	1 lib/jsbn.js

2 lib/rusha.js	2 lib/rusha.js

3	3

4 # These files can not yet be linted, see	4 # These files can not yet be linted, see

5 # https://issues.adblockplus.org/ticket/4796	5 # https://issues.adblockplus.org/ticket/4796
Sebastian Noack 2017/02/21 11:11:55 I really dislike how PhantomJS (not even being a t I really dislike how PhantomJS (not even being a target platform but merely a test environment) limits our content scripts to ES5. This is just backwards. I'd rather require building PhantomJS, with the latest JavaScriptCore, from source, than maintaining this situation until they finally release version 2.5. kzar 2017/02/21 11:27:41 Yea, it's not ideal. I already discussed this with Show quoted text On 2017/02/21 11:11:55, Sebastian Noack wrote: > I really dislike how PhantomJS (not even being a target platform but merely a > test environment) limits our content scripts to ES5. This is just backwards. I'd > rather require building PhantomJS, with the latest JavaScriptCore, from source, > than maintaining this situation until they finally release version 2.5. Yea, it's not ideal. I already discussed this with Felix and Wladimir though, so I guess this is how it will be for now.
	6 browsertests.js

6 chrome/content/elemHideEmulation.js	7 chrome/content/elemHideEmulation.js

7 lib/common.js	8 lib/common.js

8 test/browser/elemHideEmulation.js	9 test/browser/elemHideEmulation.js

LEFT	RIGHT