Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code

Delta Between Two Patch Sets: README.md

Issue 29375915: Issue 4878 - Start using ESLint for adblockpluscore (Closed)
Left Patch Set: Addressed Sebastian's initial feedback Created Feb. 21, 2017, 6:12 a.m.
Right Patch Set: Removed unused imports Created March 15, 2017, 3:11 a.m.
Left:
Right:
Use n/p to move between diff chunks; N/P to move between comments.
Jump to:
Left: Side by side diff | Download
Right: Side by side diff | Download
« no previous file with change/comment | « .eslintrc.json ('k') | lib/common.js » ('j') | no next file with change/comment »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
LEFTRIGHT
1 Adblock Plus core 1 Adblock Plus core
2 ================= 2 =================
3 3
4 This repository contains the generic Adblock Plus code that's shared between 4 This repository contains the generic Adblock Plus code that's shared between
5 platforms. This repository is not designed to be used directly, but instead to 5 platforms. This repository is not designed to be used directly, but instead to
6 serve as a dependency for `adblockplus`, `adblockpluschrome` and 6 serve as a dependency for `adblockplus`, `adblockpluschrome` and
7 `libadblockplus`. 7 `libadblockplus`.
8 8
9 Running the unit tests 9 Running the unit tests
10 ---------------------- 10 ----------------------
(...skipping 10 matching lines...) Expand all
21 `npm test` will run all tests in the `test` directory of the repository. 21 `npm test` will run all tests in the `test` directory of the repository.
22 22
23 ### Running specific tests 23 ### Running specific tests
24 24
25 You can specify specific test files or directories on the command line, e.g.: 25 You can specify specific test files or directories on the command line, e.g.:
26 `npm test test/synchronizer.js test/browser/elemHideEmulation.html`. 26 `npm test test/synchronizer.js test/browser/elemHideEmulation.html`.
27 27
28 ### Running the browser tests in a real browser 28 ### Running the browser tests in a real browser
29 29
30 The tests under `test/browser` require a browser environment. `npm test` will 30 The tests under `test/browser` require a browser environment. `npm test` will
31 run these in a headless browser, but you can also run them in a real one by 31 run these in a headless browser, with each module being loaded in a new frame.
32 opening 32 *Note*: Currently this environment is limited to ECMAScript 5, this limitation
33 [test/browser/elemHideEmulation.html](test/browser/elemHideEmulation.html). 33 should hopefully be resolved soon.
34 34
35 Linting 35 Linting
36 ------- 36 -------
37 37
38 You can lint the code using [ESLint](http://eslint.org). 38 You can lint the code using [ESLint](http://eslint.org).
39 39
40 eslint *.js chrome lib test 40 eslint *.js chrome lib test
41 41
42 You will need to set up ESLint and our configuration first, see 42 You will need to set up ESLint and our configuration first, see
43 [eslint-config-eyeo](https://hg.adblockplus.org/codingtools/file/tip/eslint-conf ig-eyeo) 43 [eslint-config-eyeo](https://hg.adblockplus.org/codingtools/file/tip/eslint-conf ig-eyeo)
44 for more information. 44 for more information.
LEFTRIGHT

Powered by Google App Engine
This is Rietveld