README.md - Issue 29375915: Issue 4878 - Start using ESLint for adblockpluscore

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Delta Between Two Patch Sets: README.md

Issue 29375915: Issue 4878 - Start using ESLint for adblockpluscore (Closed)

Left Patch Set: Addressed Sebastian's initial feedback Created Feb. 21, 2017, 6:12 a.m.

Right Patch Set: Removed unused imports Created March 15, 2017, 3:11 a.m.

Left:
Right:

Use n/p to move between diff chunks; N/P to move between comments.

Jump to:

Left: Side by side diff | Download
Right: Side by side diff | Download

LEFT	RIGHT
1 Adblock Plus core	1 Adblock Plus core

2 =================	2 =================

3	3

4 This repository contains the generic Adblock Plus code that's shared between	4 This repository contains the generic Adblock Plus code that's shared between

5 platforms. This repository is not designed to be used directly, but instead to	5 platforms. This repository is not designed to be used directly, but instead to

6 serve as a dependency for `adblockplus`, `adblockpluschrome` and	6 serve as a dependency for `adblockplus`, `adblockpluschrome` and

7 `libadblockplus`.	7 `libadblockplus`.

8	8

9 Running the unit tests	9 Running the unit tests

10 ----------------------	10 ----------------------

(...skipping 10 matching lines...) Expand all Loading...
21 `npm test` will run all tests in the `test` directory of the repository.	21 `npm test` will run all tests in the `test` directory of the repository.

22	22

23 ### Running specific tests	23 ### Running specific tests

24	24

25 You can specify specific test files or directories on the command line, e.g.:	25 You can specify specific test files or directories on the command line, e.g.:

26 `npm test test/synchronizer.js test/browser/elemHideEmulation.html`.	26 `npm test test/synchronizer.js test/browser/elemHideEmulation.html`.

27	27

28 ### Running the browser tests in a real browser	28 ### Running the browser tests in a real browser

29	29

30 The tests under `test/browser` require a browser environment. `npm test` will	30 The tests under `test/browser` require a browser environment. `npm test` will

31 run these in a headless browser, but you can also run them in a real one by	31 run these in a headless browser, with each module being loaded in a new frame.

32 opening	32 Note: Currently this environment is limited to ECMAScript 5, this limitation

33 [test/browser/elemHideEmulation.html](test/browser/elemHideEmulation.html).	33 should hopefully be resolved soon.

34	34

35 Linting	35 Linting

36 -------	36 -------

37	37

38 You can lint the code using [ESLint](http://eslint.org).	38 You can lint the code using [ESLint](http://eslint.org).

39	39

40 eslint *.js chrome lib test	40 eslint *.js chrome lib test

41	41

42 You will need to set up ESLint and our configuration first, see	42 You will need to set up ESLint and our configuration first, see

43 [eslint-config-eyeo](https://hg.adblockplus.org/codingtools/file/tip/eslint-conf ig-eyeo)	43 [eslint-config-eyeo](https://hg.adblockplus.org/codingtools/file/tip/eslint-conf ig-eyeo)

44 for more information.	44 for more information.

LEFT	RIGHT