Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code

Delta Between Two Patch Sets: test/filterStorage_readwrite.js

Issue 29375915: Issue 4878 - Start using ESLint for adblockpluscore (Closed)
Left Patch Set: Addressed Sebastian's initial feedback Created Feb. 21, 2017, 6:12 a.m.
Right Patch Set: Removed unused imports Created March 15, 2017, 3:11 a.m.
Left:
Right:
Use n/p to move between diff chunks; N/P to move between comments.
Jump to:
Left: Side by side diff | Download
Right: Side by side diff | Download
« no previous file with change/comment | « test/filterStorage.js ('k') | test/matcher.js » ('j') | no next file with change/comment »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
LEFTRIGHT
1 /* 1 /*
2 * This file is part of Adblock Plus <https://adblockplus.org/>, 2 * This file is part of Adblock Plus <https://adblockplus.org/>,
3 * Copyright (C) 2006-2016 Eyeo GmbH 3 * Copyright (C) 2006-2016 Eyeo GmbH
4 * 4 *
5 * Adblock Plus is free software: you can redistribute it and/or modify 5 * Adblock Plus is free software: you can redistribute it and/or modify
6 * it under the terms of the GNU General Public License version 3 as 6 * it under the terms of the GNU General Public License version 3 as
7 * published by the Free Software Foundation. 7 * published by the Free Software Foundation.
8 * 8 *
9 * Adblock Plus is distributed in the hope that it will be useful, 9 * Adblock Plus is distributed in the hope that it will be useful,
10 * but WITHOUT ANY WARRANTY; without even the implied warranty of 10 * but WITHOUT ANY WARRANTY; without even the implied warranty of
11 * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the 11 * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
12 * GNU General Public License for more details. 12 * GNU General Public License for more details.
13 * 13 *
14 * You should have received a copy of the GNU General Public License 14 * You should have received a copy of the GNU General Public License
15 * along with Adblock Plus. If not, see <http://www.gnu.org/licenses/>. 15 * along with Adblock Plus. If not, see <http://www.gnu.org/licenses/>.
16 */ 16 */
17 17
18 /* globals __dirname */
19
20 "use strict"; 18 "use strict";
21 19
22 let {createSandbox, unexpectedError} = require("./_common"); 20 const {createSandbox, unexpectedError} = require("./_common");
23 21
24 let Filter = null; 22 let Filter = null;
25 let FilterNotifier = null; 23 let FilterNotifier = null;
26 let FilterStorage = null; 24 let FilterStorage = null;
27 let IO = null; 25 let IO = null;
28 let Prefs = null; 26 let Prefs = null;
29 let Subscription = null; 27 let Subscription = null;
30 let ExternalSubscription = null; 28 let ExternalSubscription = null;
31 29
32 exports.setUp = function(callback) 30 exports.setUp = function(callback)
33 { 31 {
34 let sandboxedRequire = createSandbox(); 32 let sandboxedRequire = createSandbox();
35 ( 33 (
36 {Filter} = sandboxedRequire("../lib/filterClasses"), 34 {Filter} = sandboxedRequire("../lib/filterClasses"),
37 {FilterNotifier} = sandboxedRequire("../lib/filterNotifier"), 35 {FilterNotifier} = sandboxedRequire("../lib/filterNotifier"),
38 {FilterStorage} = sandboxedRequire("../lib/filterStorage"), 36 {FilterStorage} = sandboxedRequire("../lib/filterStorage"),
39 {IO} = sandboxedRequire("./stub-modules/io"), 37 {IO} = sandboxedRequire("./stub-modules/io"),
40 {Prefs} = sandboxedRequire("./stub-modules/prefs"), 38 {Prefs} = sandboxedRequire("./stub-modules/prefs"),
41 {Subscription, ExternalSubscription} = sandboxedRequire("../lib/subscription Classes") 39 {Subscription, ExternalSubscription} = sandboxedRequire("../lib/subscription Classes")
42 ); 40 );
43 41
44 FilterStorage.addSubscription(Subscription.fromURL("~fl~")); 42 FilterStorage.addSubscription(Subscription.fromURL("~fl~"));
45 callback(); 43 callback();
46 }; 44 };
47 45
48 let testData = new Promise((resolve, reject) => 46 let testData = new Promise((resolve, reject) =>
49 { 47 {
50 let fs = require("fs"); 48 const fs = require("fs");
51 let path = require("path"); 49 const path = require("path");
52 let datapath = path.resolve(__dirname, "data", "patterns.ini"); 50 let datapath = path.resolve(__dirname, "data", "patterns.ini");
53 51
54 fs.readFile(datapath, "utf-8", (error, data) => 52 fs.readFile(datapath, "utf-8", (error, data) =>
55 { 53 {
56 if (error) 54 if (error)
57 reject(error); 55 reject(error);
58 else 56 else
59 resolve(data); 57 resolve(data);
60 }); 58 });
61 }); 59 });
(...skipping 223 matching lines...) Expand 10 before | Expand all | Expand 10 after
285 backupFile.lastModifiedTime -= 25 * 60 * 60 * 1000; 283 backupFile.lastModifiedTime -= 25 * 60 * 60 * 1000;
286 oldModifiedTime = backupFile2.lastModifiedTime; 284 oldModifiedTime = backupFile2.lastModifiedTime;
287 return saveFilters(null); 285 return saveFilters(null);
288 }).then(() => 286 }).then(() =>
289 { 287 {
290 test.notEqual(backupFile2.lastModifiedTime, oldModifiedTime, "Second backup overwritten if first one is 25 hours old"); 288 test.notEqual(backupFile2.lastModifiedTime, oldModifiedTime, "Second backup overwritten if first one is 25 hours old");
291 289
292 test.ok(!backupFile3.exists(), "Third backup not created with patternsbackup s = 2"); 290 test.ok(!backupFile3.exists(), "Third backup not created with patternsbackup s = 2");
293 }).catch(unexpectedError.bind(test)).then(() => test.done()); 291 }).catch(unexpectedError.bind(test)).then(() => test.done());
294 }; 292 };
LEFTRIGHT

Powered by Google App Engine
This is Rietveld