Keyboard Shortcuts
File
u
:
up to issue
m
:
publish + mail comments
M
:
edit review message
j
/
k
:
jump to file after / before current file
J
/
K
:
jump to next file with a comment after / before current file
Side-by-side diff
i
:
toggle intra-line diffs
e
:
expand all comments
c
:
collapse all comments
s
:
toggle showing all comments
n
/
p
:
next / previous diff chunk or comment
N
/
P
:
next / previous comment
<Up>
/
<Down>
:
next / previous line
<Enter>
:
respond to / edit current comment
d
:
mark current comment as done
Issue
u
:
up to list of issues
m
:
publish + mail comments
j
/
k
:
jump to patch after / before current patch
o
/
<Enter>
:
open current patch in side-by-side view
i
:
open current patch in unified diff view
Issue List
j
/
k
:
jump to issue after / before current issue
o
/
<Enter>
:
open current issue
#
:
close issue
Comment/message editing
<Ctrl>
+
s
or
<Ctrl>
+
Enter
:
save comment
<Esc>
:
cancel edit
Rietveld
Code Review Tool
Help
|
Bug tracker
|
Discussion group
|
Source code
Issues
All Issues
Delta Between Two Patch Sets: test/.eslintrc.json
Issue
29375915
:
Issue 4878 - Start using ESLint for adblockpluscore (Closed)
Left Patch Set: Addressed further feedback from Sebastian
Created Feb. 21, 2017, 10:35 a.m.
Right Patch Set: Removed unused imports
Created March 15, 2017, 3:11 a.m.
Left:
Base
Patch Set 1: None
Patch Set 2: Stop using commonjs, fix other problems
Patch Set 3: Addressed Sebastian's initial feedback
Patch Set 4: Addressed further feedback from Sebastian
Patch Set 5: Disable no-console for the tests
Patch Set 6: Remove shared-node-browser env and Buffer global
Patch Set 7: Rebased.
Patch Set 8: Addressed Wladimir's comments
Patch Set 9: Remove the arrow-parens rule
Patch Set 10: Fixed valid-jsdoc failures and addressed nits
Patch Set 11: Rebased
Patch Set 12: Fix Cu.imports in synchronizer.js that I missed previously
Patch Set 13: Removed unused imports
Right:
Patch Set 1: None
Patch Set 2: Stop using commonjs, fix other problems
Patch Set 3: Addressed Sebastian's initial feedback
Patch Set 4: Addressed further feedback from Sebastian
Patch Set 5: Disable no-console for the tests
Patch Set 6: Remove shared-node-browser env and Buffer global
Patch Set 7: Rebased.
Patch Set 8: Addressed Wladimir's comments
Patch Set 9: Remove the arrow-parens rule
Patch Set 10: Fixed valid-jsdoc failures and addressed nits
Patch Set 11: Rebased
Patch Set 12: Fix Cu.imports in synchronizer.js that I missed previously
Patch Set 13: Removed unused imports
Use n/p to move between diff chunks; N/P to move between comments.
Jump to:
.eslintignore
.eslintrc.json
README.md
lib/common.js
lib/coreUtils.js
lib/downloader.js
lib/elemHide.js
lib/elemHideEmulation.js
lib/events.js
lib/filterClasses.js
lib/filterListener.js
lib/filterNotifier.js
lib/filterStorage.js
lib/matcher.js
lib/notification.js
lib/rsa.js
lib/subscriptionClasses.js
lib/synchronizer.js
test/.eslintrc.json
test/_common.js
test/domainRestrictions.js
test/elemHide.js
test/elemHideEmulation.js
test/filterClasses.js
test/filterListener.js
test/filterNotifier.js
test/filterStorage.js
test/filterStorage_readwrite.js
test/matcher.js
test/notification.js
test/regexpFilters_matching.js
test/signatures.js
test/stub-modules/info.js
test/stub-modules/io.js
test/stub-modules/prefs.js
test/stub-modules/utils.js
test/subscriptionClasses.js
test/synchronizer.js
test_runner.js
Left:
Side by side diff
|
Download
Right:
Side by side diff
|
Download
« no previous file with change/comment
|
« lib/synchronizer.js
('k') |
test/_common.js »
('j') |
no next file with change/comment »
Toggle Intra-line Diffs
('i') |
Expand Comments
('e') |
Collapse Comments
('c') |
Show Comments
Hide Comments
('s')
LEFT
RIGHT
1 {
1 {
2 "env": {
2 "env": {
3 "node": true
3 "node": true
4 },
4 },
5 "rules": {
5 "rules": {
6
"max-len": "off"
6
"max-len": "off"
,
7
"no-console": "off"
7 }
8 }
8 }
9 }
LEFT
RIGHT
« lib/synchronizer.js
('k') |
test/_common.js »
('j') |
Toggle Intra-line Diffs
('i') |
Expand Comments
('e') |
Collapse Comments
('c') |
Toggle Comments
('s')
Edit Message
Issue 29375915: Issue 4878 - Start using ESLint for adblockpluscore (Closed)
Created Feb. 20, 2017, 10:02 a.m. by kzar
Modified March 16, 2017, 10:51 a.m.
Reviewers: Wladimir Palant, Felix Dahlke, Sebastian Noack
Base URL:
Comments: 182
+ 1 drafts
This is Rietveld