Issue 4878 - Start using ESLint for adblockpluscore

lib/rsa.js

 /*
  * This file is part of Adblock Plus <https://adblockplus.org/>,
  * Copyright (C) 2006-2016 Eyeo GmbH
  *
  * Adblock Plus is free software: you can redistribute it and/or modify
  * it under the terms of the GNU General Public License version 3 as
  * published by the Free Software Foundation.
  *
  * Adblock Plus is distributed in the hope that it will be useful,
  * but WITHOUT ANY WARRANTY; without even the implied warranty of
  * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the
  * GNU General Public License for more details.
  *
  * You should have received a copy of the GNU General Public License
  * along with Adblock Plus.  If not, see <http://www.gnu.org/licenses/>.
  */
+
+/* global console */
 
 "use strict";
 
 /**
  * This is a specialized RSA library meant only to verify SHA1-based signatures.
  */
 
 const {BigInteger} = require("jsbn");
 const Rusha = require("rusha");
 
@@ skipping 108 matching lines @@
   readNode(templ);
   if (pos != data.length)
     throw "Too much data";
   return out;
 }
 
 /**
  * Reads a BER-encoded RSA public key. On success returns an object with the
  * properties n and e (the components of the key), otherwise null.
  * @param {string} key
- * @return {Object|null}
+ * @return {?Object}
  */
 function readPublicKey(key)
 {
   try
   {
     return readASN1(atob(key), publicKeyTemplate);
   }
   catch (e)
   {
     console.warn("Invalid RSA public key: " + e);
@@ skipping 39 matching lines @@
     let expected = new BigInteger(rusha.digest(data), 16);
     return (sha1.compareTo(expected) == 0);
   }
   catch (e)
   {
     console.warn("Invalid encrypted signature: " + e);
     return false;
   }
 }
 exports.verifySignature = verifySignature;