.eslintrc.json - Issue 29375915: Issue 4878 - Start using ESLint for adblockpluscore

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Delta Between Two Patch Sets: .eslintrc.json

Issue 29375915: Issue 4878 - Start using ESLint for adblockpluscore (Closed)

Left Patch Set: Rebased. Created Feb. 28, 2017, 3:55 p.m.

Right Patch Set: Removed unused imports Created March 15, 2017, 3:11 a.m.

Left:
Right:

Use n/p to move between diff chunks; N/P to move between comments.

Jump to:

Left: Side by side diff | Download
Right: Side by side diff | Download

LEFT	RIGHT
1 {	1 {

2 "extends": "eslint-config-eyeo",	2 "extends": "eslint-config-eyeo",

3 "root": true,	3 "root": true,

	4 "env": {

	5 "commonjs": true

	6 },

4 "globals": {	7 "globals": {

5 "atob": true,	8 "atob": true,

6 "console": true,
Wladimir Palant 2017/03/02 14:06:42 I'd suggest removing this again, we currently don' I'd suggest removing this again, we currently don't have a console variable in Firefox modules. The only module using it is rsa.js - for the very reason that it isn't being used in Firefox. It should be explicitly declared as a global for this module only, if we decide to integrate rsa.js in Firefox (quite possible) we will either have to change the module or expose a console variable. kzar 2017/03/08 12:33:25 Done. Show quoted text On 2017/03/02 14:06:42, Wladimir Palant wrote: > I'd suggest removing this again, we currently don't have a console variable in > Firefox modules. The only module using it is rsa.js - for the very reason that > it isn't being used in Firefox. It should be explicitly declared as a global for > this module only, if we decide to integrate rsa.js in Firefox (quite possible) > we will either have to change the module or expose a console variable. Done.
7 "exports": true,

8 "module": true,

9 "onShutdown": true,	9 "onShutdown": true,

10 "require": true,

11 "Cc": true,	10 "Cc": true,

12 "Ci": true,	11 "Ci": true,

13 "Cu": true,	12 "Cu": true,

14 "FileUtils": true,

15 "Services": true,

16 "URL": true,	13 "URL": true,

17 "XPCOMUtils": true,

18 "XMLHttpRequest": true	14 "XMLHttpRequest": true

19 }	15 }

20 }	16 }

LEFT	RIGHT