Issue 4878 - Start using ESLint for adblockpluscore

test/elemHideEmulation.js

 /*
  * This file is part of Adblock Plus <https://adblockplus.org/>,
  * Copyright (C) 2006-2016 Eyeo GmbH
  *
  * Adblock Plus is free software: you can redistribute it and/or modify
  * it under the terms of the GNU General Public License version 3 as
  * published by the Free Software Foundation.
  *
  * Adblock Plus is distributed in the hope that it will be useful,
  * but WITHOUT ANY WARRANTY; without even the implied warranty of
@@ skipping 42 matching lines @@
     let matches = ElemHideEmulation.getRulesForDomain(domain)
         .map(filter => filter.text);
     test.deepEqual(matches.sort(), expectedMatches.sort(), description);
 
     ElemHideEmulation.clear();
     ElemHide.clear();
   }
 
   testSelectorMatches(
     "Ignore generic filters",
-    ["##[-abp-properties='foo']", "example.com##[-abp-properties='foo']",
-     "~example.com##[-abp-properties='foo']"],
+    [
+      "##[-abp-properties='foo']", "example.com##[-abp-properties='foo']",
+      "~example.com##[-abp-properties='foo']"
+    ],
     "example.com",
     ["example.com##[-abp-properties='foo']"]
   );
   testSelectorMatches(
     "Ignore selectors with exceptions",
-    ["example.com##[-abp-properties='foo']",
-     "example.com##[-abp-properties='bar']",
-     "example.com#@#[-abp-properties='foo']"],
-     "example.com",

[Wladimir Palant, 2017/03/02 14:07:07]

The indentation is wrong here. Should be:

[
  "example.com##[-abp-properties='foo']",
  "example.com##[-abp-properties='bar']",
  "example.com#@#[-abp-properties='foo']"
],
"example.com",

[kzar, 2017/03/08 12:33:55]

Done.

+    [
+      "example.com##[-abp-properties='foo']",
+      "example.com##[-abp-properties='bar']",
+      "example.com#@#[-abp-properties='foo']"
+    ],
+    "example.com",
     ["example.com##[-abp-properties='bar']"]
   );
   testSelectorMatches(
     "Ignore filters that include parent domain but exclude subdomain",
-    ["~www.example.com,example.com##[-abp-properties='foo']"],
-     "www.example.com",

[Wladimir Palant, 2017/03/02 14:07:07]

The added indentation is wrong here, "www.example.com" isn't part of the array
above.

[kzar, 2017/03/08 12:33:54]

Done.

+    [
+      "~www.example.com,example.com##[-abp-properties='foo']"
+    ],
+    "www.example.com",
     []
   );
   testSelectorMatches(
     "Ignore filters with parent domain if exception matches subdomain",
-    ["www.example.com#@#[-abp-properties='foo']",
-     "example.com##[-abp-properties='foo']"],
+    [
+      "www.example.com#@#[-abp-properties='foo']",
+      "example.com##[-abp-properties='foo']"
+    ],
     "www.example.com",
     []
   );
   testSelectorMatches(
     "Ignore filters for other subdomain",
-    ["www.example.com##[-abp-properties='foo']",
-     "other.example.com##[-abp-properties='foo']"],
-     "other.example.com",

[Wladimir Palant, 2017/03/02 14:07:07]

Indentation is wrong here. Should be:

[
  "www.example.com##[-abp-properties='foo']",
  "other.example.com##[-abp-properties='foo']"
],
"other.example.com",

[kzar, 2017/03/08 12:33:55]

Done.

+    [
+      "www.example.com##[-abp-properties='foo']",
+      "other.example.com##[-abp-properties='foo']"
+    ],
+    "other.example.com",
     ["other.example.com##[-abp-properties='foo']"]
   );
 
   test.done();
 };
 
 exports.testElemHideEmulationFiltersContainer = function(test)
 {
   function compareRules(description, domain, expectedMatches)
   {
     let result = ElemHideEmulation.getRulesForDomain(domain)
-        .map((filter) => filter.text);
+        .map(filter => filter.text);
     expectedMatches = expectedMatches.map(filter => filter.text);
     test.deepEqual(result.sort(), expectedMatches.sort(), description);
   }
 
   let domainFilter = Filter.fromText("example.com##filter1");
   let subdomainFilter = Filter.fromText("www.example.com##filter2");
   let otherDomainFilter = Filter.fromText("other.example.com##filter3");
 
   ElemHideEmulation.add(domainFilter);
   ElemHideEmulation.add(subdomainFilter);
@@ skipping 13 matching lines @@
 
   ElemHideEmulation.clear();
   compareRules(
     "Return no filters after clearing",
     "www.example.com",
     []
   );
 
   test.done();
 };