Issue 4878 - Start using ESLint for adblockpluscore

lib/notification.js

 /*
  * This file is part of Adblock Plus <https://adblockplus.org/>,
  * Copyright (C) 2006-2016 Eyeo GmbH
  *
  * Adblock Plus is free software: you can redistribute it and/or modify
  * it under the terms of the GNU General Public License version 3 as
  * published by the Free Software Foundation.
  *
  * Adblock Plus is distributed in the hope that it will be useful,
  * but WITHOUT ANY WARRANTY; without even the implied warranty of
@@ skipping 384 matching lines @@
   removeNotification(notification)
   {
     let index = localData.indexOf(notification);
     if (index > -1)
       localData.splice(index, 1);
   },
 
   /**
    * A callback function which listens to see if notifications were approved.
    *
-   * @callback questionListener

[Wladimir Palant, 2017/03/09 14:37:13]

It's type name, should be uppercased IMHO.

[kzar, 2017/03/10 06:56:14]

Done.

+   * @callback QuestionListener
    * @param {boolean} approved
    */
 
   /**
    * Adds a listener for question-type notifications
    * @param {string} id
-   * @param {questionListener} listener
+   * @param {QuestionListener} listener
    */
   addQuestionListener(id, listener)
   {
     if (!(id in questionListeners))
       questionListeners[id] = [];
     if (questionListeners[id].indexOf(listener) === -1)
       questionListeners[id].push(listener);
   },
 
   /**
    * Removes a listener that was previously added via addQuestionListener
    * @param {string} id
-   * @param {questionListener} listener
+   * @param {QuestionListener} listener
    */
   removeQuestionListener(id, listener)
   {
     if (!(id in questionListeners))
       return;
     let index = questionListeners[id].indexOf(listener);
     if (index > -1)
       questionListeners[id].splice(index, 1);
     if (questionListeners[id].length === 0)
       delete questionListeners[id];
@@ skipping 30 matching lines @@
     else if (index != -1 && forceValue !== true)
       categories.splice(index, 1);
 
     // HACK: JSON values aren't saved unless they are assigned a
     // different object.
     Prefs.notifications_ignoredcategories =
       JSON.parse(JSON.stringify(categories));
   }
 };
 Notification.init();