Issue 4878 - Start using ESLint for adblockpluscore

test/_common.js

 /*
  * This file is part of Adblock Plus <https://adblockplus.org/>,
  * Copyright (C) 2006-2016 Eyeo GmbH
  *
  * Adblock Plus is free software: you can redistribute it and/or modify
  * it under the terms of the GNU General Public License version 3 as
  * published by the Free Software Foundation.
  *
  * Adblock Plus is distributed in the hope that it will be useful,
  * but WITHOUT ANY WARRANTY; without even the implied warranty of
@@ skipping 65 matching lines @@
   atob: data => new Buffer(data, "base64").toString("binary"),
   btoa: data => new Buffer(data, "binary").toString("base64"),
   Ci: {
   },
   Cu: {
     import(resource)
     {
       let match = /^resource:\/\/gre\/modules\/(.+)\.jsm$/.exec(resource);
       let resourceName = match && match[1];
       if (resourceName && resources.hasOwnProperty(resourceName))
         return {[resourceName]: resources[resourceName]};

[Wladimir Palant, 2017/03/09 14:37:14]

This is a good case for the consistent-return rule :)

Please throw an exception for unknown imports, this will make sure that issues
don't manifest only much further down.

  throw new Error("Attempt to import unknown JavaScript module " + resource);

[kzar, 2017/03/10 06:56:14]

Done.

+
+      throw new Error(
+        "Attempt to import unknown JavaScript module " + resource
+      );
     },
     reportError(e) {}
   },
   console: {
     log() {},
     error() {}
   },
   navigator: {
   },
   onShutdown: {
@@ skipping 334 matching lines @@
       round: Math.round
     }
   };
 };
 
 exports.unexpectedError = function(error)
 {
   console.error(error);
   this.ok(false, "Unexpected error: " + error);
 };