Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code

Unified Diff: test/subscriptionClasses.js

Issue 29375915: Issue 4878 - Start using ESLint for adblockpluscore (Closed)
Patch Set: Addressed Wladimir's comments Created March 8, 2017, 12:28 p.m.
Use n/p to move between diff chunks; N/P to move between comments.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « test/stub-modules/utils.js ('k') | test/synchronizer.js » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: test/subscriptionClasses.js
diff --git a/test/subscriptionClasses.js b/test/subscriptionClasses.js
index 61767551aba879ccfde595c3774c9067af0d2997..38771f9e1e1a17959b23c869e0e9dfdf4d0b44ee 100644
--- a/test/subscriptionClasses.js
+++ b/test/subscriptionClasses.js
@@ -17,7 +17,7 @@
"use strict";
-let {createSandbox} = require("./_common");
+const {createSandbox} = require("./_common");
let Subscription = null;
let SpecialSubscription = null;
@@ -72,31 +72,44 @@ exports.testSubscriptionsWithState = function(test)
{
compareSubscription(test, "~fl~", ["url=~fl~"]);
compareSubscription(test, "http://test/default", ["url=http://test/default", "title=http://test/default"]);
- compareSubscription(test, "http://test/default_titled", ["url=http://test/default_titled", "title=test"], function(subscription)
- {
- subscription.title = "test";
- });
- compareSubscription(test, "http://test/non_default", ["url=http://test/non_default", "title=test",
- "disabled=true", "lastSuccess=8", "lastDownload=12", "lastCheck=16", "softExpiration=18", "expires=20", "downloadStatus=foo",
- "errors=3", "version=24", "requiredVersion=0.6"], function(subscription)
- {
- subscription.title = "test";
- subscription.disabled = true;
- subscription.lastSuccess = 8;
- subscription.lastDownload = 12;
- subscription.lastCheck = 16;
- subscription.softExpiration = 18;
- subscription.expires = 20;
- subscription.downloadStatus = "foo";
- subscription.errors = 3;
- subscription.version = 24;
- subscription.requiredVersion = "0.6";
- });
- compareSubscription(test, "~wl~", ["url=~wl~", "disabled=true", "title=Test group"], function(subscription)
- {
- subscription.title = "Test group";
- subscription.disabled = true;
- });
+ compareSubscription(
+ test, "http://test/default_titled", ["url=http://test/default_titled", "title=test"],
+ subscription =>
+ {
+ subscription.title = "test";
+ }
+ );
+ compareSubscription(
+ test, "http://test/non_default",
+ [
+ "url=http://test/non_default", "title=test", "disabled=true",
+ "lastSuccess=8", "lastDownload=12", "lastCheck=16", "softExpiration=18",
+ "expires=20", "downloadStatus=foo", "errors=3", "version=24",
+ "requiredVersion=0.6"
+ ],
+ subscription =>
+ {
+ subscription.title = "test";
+ subscription.disabled = true;
+ subscription.lastSuccess = 8;
+ subscription.lastDownload = 12;
+ subscription.lastCheck = 16;
+ subscription.softExpiration = 18;
+ subscription.expires = 20;
+ subscription.downloadStatus = "foo";
+ subscription.errors = 3;
+ subscription.version = 24;
+ subscription.requiredVersion = "0.6";
+ }
+ );
+ compareSubscription(
+ test, "~wl~", ["url=~wl~", "disabled=true", "title=Test group"],
+ subscription =>
+ {
+ subscription.title = "Test group";
+ subscription.disabled = true;
+ }
+ );
test.done();
};
« no previous file with comments | « test/stub-modules/utils.js ('k') | test/synchronizer.js » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld