Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code

Unified Diff: test/regexpFilters_matching.js

Issue 29375915: Issue 4878 - Start using ESLint for adblockpluscore (Closed)
Patch Set: Rebased Created March 10, 2017, 7:02 a.m.
Use n/p to move between diff chunks; N/P to move between comments.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « test/notification.js ('k') | test/signatures.js » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: test/regexpFilters_matching.js
diff --git a/test/regexpFilters_matching.js b/test/regexpFilters_matching.js
index 8017945dece3c8853665ef668be1446d22647eaa..0336659c67733215303ec1da1b94115f05aff20b 100644
--- a/test/regexpFilters_matching.js
+++ b/test/regexpFilters_matching.js
@@ -17,7 +17,7 @@
"use strict";
-let {createSandbox} = require("./_common");
+const {createSandbox} = require("./_common");
let Filter = null;
let RegExpFilter = null;
@@ -36,15 +36,16 @@ exports.setUp = function(callback)
function testMatch(test, text, location, contentType, docDomain, thirdParty, sitekey, expected)
{
- function testMatch_internal(text, location, contentType, docDomain, thirdParty, sitekey, expected)
+ function testMatchInternal(filterText)
{
- let filter = Filter.fromText(text);
+ let filter = Filter.fromText(filterText);
let result = filter.matches(location, RegExpFilter.typeMap[contentType], docDomain, thirdParty, sitekey);
- test.equal(!!result, expected, '"' + text + '".matches(' + location + ", " + contentType + ", " + docDomain + ", " + (thirdParty ? "third-party" : "first-party") + ", " + (sitekey || "no-sitekey") + ")");
+ test.equal(!!result, expected, '"' + filterText + '".matches(' + location + ", " + contentType + ", " + docDomain + ", " + (thirdParty ? "third-party" : "first-party") + ", " + (sitekey || "no-sitekey") + ")");
}
- testMatch_internal(text, location, contentType, docDomain, thirdParty, sitekey, expected);
+
+ testMatchInternal(text);
if (!/^@@/.test(text))
- testMatch_internal("@@" + text, location, contentType, docDomain, thirdParty, sitekey, expected);
+ testMatchInternal("@@" + text);
}
exports.testBasicFilters = function(test)
« no previous file with comments | « test/notification.js ('k') | test/signatures.js » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld